Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript Typings (rename and export Options interface) #206

Merged
merged 4 commits into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@Kocal
Copy link
Contributor

Kocal commented Apr 9, 2019

Hi, this PR is like a small following of #189.

Before #189 was created, we add to install package @types/rollup-plugin-node-resolve (source) to make this plugin usable in a TypeScript environment.

The typings exported an interface Options, so I did the same here to minimize code updates for people that use import { Options } from 'rollup-plugin-node-resolve'.

Thanks :)

Kocal added some commits Apr 9, 2019

@Kocal Kocal changed the title Fix TypeScript Typings Fix TypeScript Typings (rename and export Options interface) Apr 9, 2019

@lukastaegert
Copy link
Member

lukastaegert left a comment

Looks good to me

@lukastaegert lukastaegert merged commit f582f9c into rollup:master Apr 10, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Kocal Kocal deleted the Kocal:type/export-options-interface branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.