New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`output.format`: es deletes "quotes" from renamed exports #5286

Closed

DougAnderson444 opened this issue Dec 6, 2023 · 2 comments · Fixed by #5298

Labels

t¹ 🐞 bug t⁸ ⋅ triage

DougAnderson444 commented Dec 6, 2023

Rollup Version

3.25.1

Operating System (or Browser)

Chrome

Node Version (if applicable)

18

Link To Reproduction

https://rollupjs.org/repl/?version=4.6.1&shareable=JTdCJTIyZXhhbXBsZSUyMiUzQW51bGwlMkMlMjJtb2R1bGVzJTIyJTNBJTVCJTdCJTIyY29kZSUyMiUzQSUyMiUyRiUyRiUyME5BTUVEJTIwRVhQT1JUUyU1Q24lMkYlMkYlMjBUaGVyZSUyMGFyZSUyMG1hbnklMjB3YXlzJTIwdG8lMjBleHBvcnQlMjBiaW5kaW5ncyU1Q24lMkYlMkYlMjBmcm9tJTIwYW4lMjBFUzIwMTUlMjBtb2R1bGUlNUNuZnVuY3Rpb24lMjBiYXooKSUyMCU3QiU1Q24lNUN0cmV0dXJuJTIwYmFyKCklM0IlNUNuJTdEJTVDbiU1Q25leHBvcnQlMjAlN0IlMjBiYXolMjBhcyUyMCU1QyUyMmJhel9yZW5hbWVkJTNBaW4lMkZxdW90ZXMlNUMlMjIlMjAlN0QlM0IlMjIlMkMlMjJpc0VudHJ5JTIyJTNBdHJ1ZSUyQyUyMm5hbWUlMjIlM0ElMjJtYWluLmpzJTIyJTdEJTJDJTdCJTIyY29kZSUyMiUzQSUyMmV4cG9ydCUyMGNvbnN0JTIwcXV4JTIwJTNEJTIwJ1FVWCclM0IlMjIlMkMlMjJpc0VudHJ5JTIyJTNBZmFsc2UlMkMlMjJuYW1lJTIyJTNBJTIycXV4LmpzJTIyJTdEJTVEJTJDJTIyb3B0aW9ucyUyMiUzQSU3QiUyMm91dHB1dCUyMiUzQSU3QiUyMmZvcm1hdCUyMiUzQSUyMmVzJTIyJTdEJTdEJTdE

Expected Behaviour

If I rollup

export { baz as "baz_renamed:in/quotes" };

I expect the ES bundle to keep the quoted export name:

export { baz as "baz_renamed:in/quotes" };

Discovered via bytecodealliance/jco#292 where "package:name/imports" as re-exported in quotes.

Actual Behaviour

// error! Invalid syntax.
export { baz as baz_renamed:in/quotes };

DougAnderson444 added t¹ 🐞 bug t⁸ ⋅ triage labels

lukastaegert mentioned this issue

Fully support arbitrary module namespace identifiers for all formats #5298

Merged

9 tasks

Member

lukastaegert commented Dec 12, 2023

This should have been done a long time ago. Fix at last at #5298.

lukastaegert closed this as completed in #5298

github-actions bot commented Dec 13, 2023

This issue has been resolved via #5298 as part of rollup@4.9.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment