Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use module instead of jsnext:main in documentation #969

Closed
GGAlanSmithee opened this issue Sep 21, 2016 · 5 comments
Closed

use module instead of jsnext:main in documentation #969

GGAlanSmithee opened this issue Sep 21, 2016 · 5 comments

Comments

@GGAlanSmithee
Copy link

In the documentation of rollup, jsnext:main is used to signify the entry point of code using es2015 module syntax. Since the node-resolve plugin now supports module, it would IMO be favorable to use this in the documentation instead;

In time jsnext:main could be dropped in favor of module and the ecosystem would be a bit less fragmented.

@TrySound
Copy link
Member

#818

@GGAlanSmithee
Copy link
Author

GGAlanSmithee commented Sep 21, 2016

@TrySound sorry for the dupe, I tried searching for it but the terms "module" / "jsnext:main" was to broad and turned up pages of issues, so missed it.

Out of curiousity, since you closed #818, is this proposal rejected? If not, want help updating the docs?

@TrySound
Copy link
Member

Closed in favour of this issue.

@GGAlanSmithee
Copy link
Author

@TrySound ah ok, tell me if this is something you want to see done, and I'd be glad to help out.

jaydenseric added a commit to jaydenseric/scroll-animator that referenced this issue Oct 3, 2016
- Fixed a typo in the `scrollToElement` function that was causing a console error when the container scroll dimensions change during a scroll animation.
- More correct use of ES6 `const` and `let`.
- Reordered some code in the `animateScroll` function for readability.
- Corrected JSDoc `@param` type capitalizations.
- Now using the Barebones ESLint sharable config.
- Renamed the `lib` folder `src`. This is more conventional.
- Using `module` in place of `jsnext:main` in `package.json`. See webpack/webpack#1979 and rollup/rollup#969.
- Renamed the `skid.mjs` module dist file `skid.module.js`. The `.mjs` extension thankfully looks like it is not catching on.
- Dependency updates.
- I was going to release with v0.1.0, but it turns out it is a better practice to kick off with v1.0.0. Hence the jump.
jaydenseric added a commit to jaydenseric/Hurdler that referenced this issue Nov 14, 2016
….mjs extension.

See webpack/webpack#1979 and rollup/rollup#969. Renamed the `hurdler.mjs` module dist file `hurdler.module.js`. The `.mjs` extension thankfully looks like it is not catching on.
@Rich-Harris
Copy link
Contributor

Wiki has been updated – thanks

karlhorky added a commit to karlhorky/react-arrow that referenced this issue Jun 13, 2019
Yankovsky referenced this issue in tonai/storybook-addon-themes Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants