Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): es6 output format is deprecated #2349

Merged
merged 2 commits into from
Jul 31, 2018

Conversation

bitjson
Copy link
Contributor

@bitjson bitjson commented Jul 23, 2018

Error: The es6 output format is deprecated – use es instead

Error: The `es6` output format is deprecated – use `es` instead
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, thanks!

@lukastaegert
Copy link
Member

Actually you should be using esm instead of es which we added to align with how this format is referenced in many other places. The ultimate plan is to deprecate es as well at some point. I guess there is no harm in deprecating es in the types now?

@bitjson
Copy link
Contributor Author

bitjson commented Jul 24, 2018

Good to know. I'd recommend making that change in the same PR which changes the error message and documentation. (In the docs, I don't see esm mentioned?)

@lukastaegert
Copy link
Member

In the docs, I don't see esm mentioned?

Good point, will need to take a look.

@lukastaegert
Copy link
Member

Docs PR: rollup/rollupjs.org#143

@guybedford
Copy link
Contributor

Probably sensible to leave both es and esm for now?

@lukastaegert
Copy link
Member

I vote for removing "es" it from the types but leaving it in the code. Thus everything will still work but TS users will be notified to change it. Then maybe in the 1.0.0, we can display a warning if "es" is used instead of "esm".

@lukastaegert lukastaegert merged commit 9eaa1d9 into rollup:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants