Add a test that should fail, but doesn’t. #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,5 @@ | |||
| var assert = require( 'assert' ); | |||
There was a problem hiding this comment.
Unnecessary assert import?
We were inadvertantly extempting any references within an export named declaration, but we should only extempt the declared identifiers from being assumed globals.
|
Okay, I figured out the fix, and yes, I did introduce a bug. 😦 |
Rich-Harris
added a commit
that referenced
this pull request
Nov 4, 2015
|
Okay, I removed the extraneous requires. |
I think it's more a case of exposing a pre-existing bug! I was taking a look at the same time and came upon an alternative fix, which is to disregard re-exports altogether in the initial analysis – will add a PR in a sec |
|
Nice, thanks for investigating. |
mbostock
added a commit
to d3/d3-color
that referenced
this pull request
Nov 4, 2015
Rich-Harris
added a commit
that referenced
this pull request
Nov 4, 2015
Disregard re-export statements
|
Thanks for the test! Released 0.20.5 with the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I may have broken something in my previous fix?