fix: conditional/logical expression should request a new tree-shaking

[liuly0322]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:

• resolves TypeError: Cannot read properties of null (reading 'render') #5480

Description

While we should not request a tree-shaking in ConditionalExpression or LogicalExpression if nothing happens; we should request one if anything changes.

One way to validate this fix is to use example from #5480, see repl, another one is to use index.js from https://github.com/elchininet/shadow-dom-selector

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rollup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 21, 2024 5:25pm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (38fe707) to head (47fd8ba).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5481   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         238      238           
  Lines        9554     9560    +6     
  Branches     2439     2444    +5     
=======================================
+ Hits         9443     9449    +6     
  Misses         46       46           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lukastaegert]

👍 Thanks for quickly looking into this!

[github-actions]

This PR has been released as part of rollup@4.16.1. You can test it via npm install rollup.