Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work with KeepKey #8

Closed
wants to merge 3 commits into from
Closed

Make it work with KeepKey #8

wants to merge 3 commits into from

Conversation

bgok
Copy link
Contributor

@bgok bgok commented Jan 14, 2016

No description provided.

@romanz romanz self-assigned this Jan 14, 2016
@romanz
Copy link
Owner

romanz commented Jan 14, 2016

Thanks!
I will merge it tomorrow :)

@romanz
Copy link
Owner

romanz commented Jan 15, 2016

I have done a bit of refactoring at https://github.com/keepkey/trezor-agent/pull/1.
Please take a look and make sure it works with KeepKey.

@romanz
Copy link
Owner

romanz commented Jan 15, 2016

When it works, I will merge it to the master branch and create a new release at PyPI.

@bgok
Copy link
Contributor Author

bgok commented Jan 15, 2016

I'll try it when I get to the office. I thought about doing the semvar change, so I'm glad to see that you did. In general, the changes you made are a much cleaner approach. Thanks for taking the time to get this working.

@romanz
Copy link
Owner

romanz commented Jan 15, 2016

Thanks :)

@romanz
Copy link
Owner

romanz commented Jan 15, 2016

Maybe it's better to handle the last commit in a separate PR...

@bgok
Copy link
Contributor Author

bgok commented Jan 15, 2016

Yeah, probably a good idea. The fix isn't working correctly anyway. Works for @dstanchfield, but not for me. Here's the error without the change:

Traceback (most recent call last):
File "build/bdist.macosx-10.10-x86_64/egg/trezor_agent/server.py", line 42, in handle_connection
msg = util.read_frame(conn)
File "build/bdist.macosx-10.10-x86_64/egg/trezor_agent/util.py", line 37, in read_frame
size, = recv(conn, '>L')
File "build/bdist.macosx-10.10-x86_64/egg/trezor_agent/util.py", line 24, in recv
buf = _read(size)
error: [Errno 35] Resource temporarily unavailable

@romanz
Copy link
Owner

romanz commented Jan 15, 2016

I will open a new issue for this tomorrow (I am at GMT+2 timezone...)

Could you please record the session using http://asciinema.org/ so that the timing of the error will be visible? Also, please run trezor-agent with "-vv" for DEBUG logging level.

@romanz
Copy link
Owner

romanz commented Jan 16, 2016

Thanks for opening #9.
I have merged this branch (up to https://github.com/keepkey/trezor-agent/commit/8c6ac43cf4992d1c4a72e89d976c2f5678b5615e) to master branch.

@romanz romanz closed this Jan 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants