-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it work with KeepKey #8
Conversation
Thanks! |
I have done a bit of refactoring at https://github.com/keepkey/trezor-agent/pull/1. |
When it works, I will merge it to the |
I'll try it when I get to the office. I thought about doing the semvar change, so I'm glad to see that you did. In general, the changes you made are a much cleaner approach. Thanks for taking the time to get this working. |
Thanks :) |
Maybe it's better to handle the last commit in a separate PR... |
Yeah, probably a good idea. The fix isn't working correctly anyway. Works for @dstanchfield, but not for me. Here's the error without the change: Traceback (most recent call last): |
I will open a new issue for this tomorrow (I am at GMT+2 timezone...) Could you please record the session using http://asciinema.org/ so that the timing of the error will be visible? Also, please run trezor-agent with "-vv" for DEBUG logging level. |
Thanks for opening #9. |
No description provided.