romcal 2.0.0 βeta #250
Merged
romcal 2.0.0 βeta #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typedoc only runs on core branches
…21 (#261) & other l10n improvements * Implement changes in the GRC based on the decreed from 2 Feb 2021 - Change `martha_of_bethany` to `martha_of_bethany_mary_of_bethany_and_lazarus_of_bethany` (see [decree B0066](https://press.vatican.va/content/salastampa/it/bollettino/pubblico/2021/02/02/0066/00135.html)); - Add the following three celebrations to the GRC (see [decree B0065](https://press.vatican.va/content/salastampa/it/bollettino/pubblico/2021/02/02/0065/00136.html)): - `gregory_of_narek_abbot`; - `hildegard_of_bingen_abbess`; - `john_of_avila_priest`; - Add localised celebration name of `gregory_of_narek_abbot` to all supported locales; - `sk`: Fix localisation of `hildegard_of_bingen_abbess`; - `pt-br`: Add localised keys for all three celebrations added to the GRC. * Fix `martha_of_bethany_mary_of_bethany_and_lazarus_of_bethany` in `en.ts`. * Fix the title issue of `john_of_avila_priest`
My private fork is now quite diverging from this codebase. But it allowed me to address quickly some requirements for a project I was working on. This was also a good place to experiments new features, that I think I need to polish or redesign before adding them here 😉 |
General names. Fix TODOs - in Polish primary patron is called 'główny' and secondary has no extra word. Lowercase bishop title. Re-translate and lowercase priest title. Lowercase martyr title. Commas for companions. Commas for patrons. Some other typos. Add missing translations for keys from calendars/poland.js: * joseph_sebastian_pelczar_bishop * our_lady_queen_of_poland * our_lady_help_of_christians * hedwig_of_poland * dedication_of_consecrated_churches
|
BOOM! 🎆 |
This was referenced May 18, 2021
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contain the rewrite of all the codebase, converted to TypeScript. So this is a major pull request!
🚀 A way to test it, is to install this branch (just rebased from
dev) and play with romcal. But we will take the required time on thedevbranch to test this new beta release, and do everything that need to be done before a final release.📚 Please also have a look to the new README.md.
This major code rewrite was also a good opportunity to bring new features, refactor the romcal API, and address a few things:
weekdaytoferia(rollback) #88, closesliturgicalColor: return localised name instead of hexadecimal value #177, closes Early/Later Ordinary Time #170).weekdaycycle metadata (closes Add ferial cycles #75)psalterWeekmetadata according to the guideline of the liturgy of the hours (related and closes Custom/Proper in psalter weeks #220)isHolyDayOfObligationmetadata (closes Holy Days of Obligation #76).ascensionOnSunday,corpusChristiOnSunday,epiphanyOnSundayoption names are now unified (closes Unify the config variables / option names #163)christmastideIncludesTheSeasonOfEpiphanyhas been removed (closes IschristmastideIncludesTheSeasonOfEpiphanyoption relevant? #212)calendaris renamed toscopeand take the values:gregorianorliturgicalyearnow correspond to the second year (the almost whole part of the civil year) (closes Liturgical year should be the second year (the almost whole part of the civil year) #216).outputOptionalMemorials(closes Multiple celebration options on one day #74)method has been removed. A.groupBy` and filter methods has been added. Related documentation has been added. (closes Utility of the.queryFormethod #215)verbose(andprettyPrint) option has been added. It only works on Node.js, but help is wanted to make it work on the browser too.snake_case, more readable and JavaScript agnostic (closes Proof the strings inen.tsand create specific rules how to generate key names #175).README.MDcleanup #61, closes_F-TypeScript: Build and test #184). You will also notice the new romcal logo (closes Createromcallogo/icon #62).nationalcalendars are renamed toparticular(closes Change ‘national’ to ‘particular’ (calendars) #73)blackliturgical color (closes Add black liturgical colour #200)date,rank... ), except thenameproperty (e.g. if you want to add "Patron of..."). The extend feature of thenameproperty will be added with the help of an i18n library.A big thank you @pejulian for daring this big codebase rewrite and refactor on TypeScript, and for all your help and support! And @tukusejssirs for the massive work you make on calendar and localisation data, proofing and making them always better, and for all your vision and suggestions to this project, all of that is invaluable!
This is another big step towards to make romcal 2.0 happen! But there is still work to do 😉
When this PR will be merged in
dev, next PRs will be lighter and easier to review. This will also help future contributors to onboard on this project. Here it was an exception due to the change to TypeScript, and all feature and API refactor it bring.