This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): analyzer metadata #4368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two new metadata to the analyzer infrastructure:
file_path
of the file being analyzed; this will be useful for some other rules that like Naming conventions #4282.SourceType
, which will allow making the rules smarter. In this PR, I updatednoUndeclaredVariables
, where the rule doesn't check TypeScript global variables if the file being analyzed is a JavaScript file.Test Plan
I created a new test case for the rule that was updated
Changelog
Documentation