Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): analyzer metadata #4368

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

ematipico
Copy link
Contributor

Summary

This PR adds two new metadata to the analyzer infrastructure:

  • the file_path of the file being analyzed; this will be useful for some other rules that like Naming conventions #4282.
  • the SourceType, which will allow making the rules smarter. In this PR, I updated noUndeclaredVariables, where the rule doesn't check TypeScript global variables if the file being analyzed is a JavaScript file.

Test Plan

I created a new test case for the rule that was updated

Changelog

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Apr 12, 2023

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit 6e6226d
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64367f434a5e080008a66042
😎 Deploy Preview https://deploy-preview-4368--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added A-Linter Area: linter A-Project Area: project configuration and loading A-Tooling Area: our own build, development, and release tooling labels Apr 12, 2023
@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 48647 48647 0
Passed 47568 47568 0
Failed 1079 1079 0
Panics 0 0 0
Coverage 97.78% 97.78% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6093 6093 0
Passed 1783 1783 0
Failed 4310 4310 0
Panics 0 0 0
Coverage 29.26% 29.26% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 568 568 0
Failed 71 71 0
Panics 0 0 0
Coverage 88.89% 88.89% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16740 16740 0
Passed 12803 12803 0
Failed 3937 3937 0
Panics 0 0 0
Coverage 76.48% 76.48% 0.00%

Copy link
Contributor

@nissy-dev nissy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ematipico ematipico merged commit 0133f40 into main Apr 12, 2023
@ematipico ematipico deleted the feat/analyzer-metadata branch April 12, 2023 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter A-Project Area: project configuration and loading A-Tooling Area: our own build, development, and release tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants