This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
github-actions
bot
added
A-CLI
Area: CLI
A-Core
Area: core
A-Diagnostic
Area: errors and diagnostics
A-Project
Area: project configuration and loading
labels
Apr 14, 2023
ematipico
force-pushed
the
feat/gitignore-support
branch
from
April 14, 2023 15:52
2c67cda
to
139a6b0
Compare
github-actions
bot
added
A-Linter
Area: linter
and removed
A-Diagnostic
Area: errors and diagnostics
labels
Apr 14, 2023
ematipico
force-pushed
the
feat/gitignore-support
branch
from
April 15, 2023 18:25
139a6b0
to
2e82ec6
Compare
denbezrukov
approved these changes
Apr 17, 2023
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2492
This PR adds an opt-in integration of Rome with a VCS.
The integration can be set via configuration of via CLI:
Configuration of
rome.json
:CLI:
The
root
option in an optional flag tells Rome where to look for VCS files. Theroot
will work as follow:If
root
is passed:rome.json
is present, rome will appendroot
to the configuration path to discover the VCS files;rome.json
is not present, rome will appendroot
to the working directory to discover the VCS files;rome.json
is not present, and the working directory is not present, rome will use the current path to discover the VCS files;If
root
is not passed:rome.json
is present, rome will use the configuration path to discover the VCS files;rome.json
is not present, rome will use the working directory to discover the VCS files;rome.json
is not present, and the working directory is not present, rome will use the current path to discover the VCS files;As for now, the only feature that this PR does add to Rome is the possibility of ignoring files via
.gitignore
file. Though, there's a limitation: in this PR, multiple.gitignore
files are a non-goal, and the only ignore file that is read is the one present in theroot
We might add this functionality later when we feel the whole architecture behind it is stable.Test Plan
Added test cases for
format
,check
andci
commands.Changelog
Documentation