This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): useLiteralEnumMembers #4409
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements prefer-literal-enum-member with a minor change: we accept all constant bitwise expressions while ESlint accepts only unary bitwise expressions with a single number and binary bitwise expressions with two number. ESLint reauires also to enable an option to allow bitwise expressions.
For instance, this rule accepts the following enum, while ESLint rejects it:
Test Plan
ESLint tests included.
Changelog
Changelog entry added
Documentation