Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

perf: improve rome benchmark performance in formatting by removing di… #4475

Merged
merged 1 commit into from
May 15, 2023

Conversation

connorjburton
Copy link
Contributor

…agnostics

Summary

The benchmark tool was not passing --max-diagnostics=0 when performing the format benchmark for rome. It should be set as none of the other tools have any significant output - unlike rome, which by default was outputting up to 20 diagnostics per run.

This improved rome's performance in the format benchmark to the x25 speed improvement over Prettier, which is advertised on the homepage of the project. Without this, rome performed worse than dprint.

Test Plan

N/A

Changelog

I don't believe this requires a changelog entry

  • The PR requires a changelog line

Documentation

The documentation was wrong before, this makes the documentation accurate again.

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented May 14, 2023

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit d0fc67a
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64610eabdd09d600083a0b97

@connorjburton connorjburton changed the title e,perf: improve rome benchmark performance in formatting by removing di… perf: improve rome benchmark performance in formatting by removing di… May 14, 2023
@Conaclos
Copy link
Contributor

Thanks!

@Conaclos Conaclos merged commit 505bac2 into rome:main May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants