Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ember-cli-head 0.4.0 #60

Closed
wants to merge 5 commits into from
Closed

Conversation

reidab
Copy link

@reidab reidab commented Nov 5, 2017

We ran into some pretty hairy problems with lazy-loaded engines after upgrading ember-cli-head to 0.4.0 when ember-cli-meta-tags was still requiring 0.3.0 and adding its head-layout-injecting instance-initializer.

This PR:

  • Updates the ember-cli-head dependency to ^0.4.0
  • Drops support for Embers older than 2.10, when -in-element was introduced
  • Switches to using versionCompatibility to generate ember-try scenarios
  • Bumps the package version to 5.0.0, since this upgrade requires manual work to add {{head-layout}}
  • Adds a note to the README

@eshtadc
Copy link

eshtadc commented Nov 14, 2017

Something I'm interested in as well. Please let me know if I can help.

@CvX
Copy link

CvX commented Dec 5, 2017

I'm already using this version in a production app. Would be great if we could get these changes released!

@begedin
Copy link
Collaborator

begedin commented Dec 6, 2017

👍 on getting this merged. Our other dependency, https://github.com/tim-evans/ember-page-title has updated to ember-cli-head@0.4.0 and no longer has this issue, but this addon is preventing us from updating further.

It relates to this issue ember-fastboot/ember-cli-head#33

@joshsmith
Copy link

Hi @ronco just wanted to check in and see if you had any plans to merge and release this?

@ronco
Copy link
Owner

ronco commented Dec 15, 2017 via email

@joshsmith
Copy link

@ronco sure, I'd be happy to help.

@begedin
Copy link
Collaborator

begedin commented Dec 18, 2017

@ronco Same here

@joshsmith
Copy link

@ronco If you wanted to transfer you could do so to the @code-corps organization on GitHub, and to @joshsmith on npm. Just let me know!

@Duder-onomy
Copy link

Duder-onomy commented Feb 6, 2018

@ronco Can we get @joshsmith and @begedin added to this project?
I am about to make another PR for fastboot support and I cannot tell the current state of the repo as there are a bunch of legitimate pending PR's. This is a great lib and allot of people use it. If your not using Ember anymore, can you let your birdie fly free?

@ronco
Copy link
Owner

ronco commented Feb 6, 2018

@Duder-onomy Done. Sorry about the radio silence. @joshsmith @begedin You should be collaborators now.

@snewcomer
Copy link
Collaborator

@ronco It would be great to pickup the activity again on this repo. I use it on a few large projects and would love to help triage issues and update the lib. Would it be possible to add me as a collaborator?

@chriskrycho
Copy link

Plus one from me on cutting a release with these changes, @joshsmith and @begedin; and/or adding @snewcomer so they can do it. We're kind of hard-blocked on updating to Ember 2.18 (much less 3.x) by this – so if something doesn't get cut soon we'll have to fork it and pin to a specific hash in the forked repository until it does, which is seriously our least favorite thing ever. 😬

@snewcomer snewcomer mentioned this pull request Jun 21, 2018
@reidab
Copy link
Author

reidab commented Jun 26, 2018

This was superseded by #71 🎉

@reidab reidab closed this Jun 26, 2018
@begedin
Copy link
Collaborator

begedin commented Jun 27, 2018

@reidab Thank you for your work and apologies for the huge delay, but hopefully 5.0 will do the trick for most people. We can focus on moving this library forward now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants