setup.py test results on 1.14.0

[ndowens]

FAIL: test_get_not_permitted (tests.test_sftp._TestSCP)
Test getting a file with no read permissions over SCP

Traceback (most recent call last):
File "/usr/local/poudriere/ports/head/security/py-asyncssh/work-py36/asyncssh-1.14.0/tests/util.py", line 77, in async_wrapper
return self.loop.run_until_complete(wrapped_func)
File "/usr/local/lib/python3.6/asyncio/base_events.py", line 468, in run_until_complete
return future.result()
File "/usr/local/poudriere/ports/head/security/py-asyncssh/work-py36/asyncssh-1.14.0/tests/test_sftp.py", line 2798, in test_get_not_permitted
yield from scp((self._scp_server, 'src'), 'dst')
AssertionError: SFTPError not raised

======================================================================
FAIL: test_get_not_permitted (tests.test_sftp._TestSCPAsync)
Test getting a file with no read permissions over SCP

Traceback (most recent call last):
File "/usr/local/poudriere/ports/head/security/py-asyncssh/work-py36/asyncssh-1.14.0/tests/util.py", line 77, in async_wrapper
return self.loop.run_until_complete(wrapped_func)
File "/usr/local/lib/python3.6/asyncio/base_events.py", line 468, in run_until_complete
return future.result()
File "/usr/local/poudriere/ports/head/security/py-asyncssh/work-py36/asyncssh-1.14.0/tests/test_sftp.py", line 2798, in test_get_not_permitted
yield from scp((self._scp_server, 'src'), 'dst')
AssertionError: SFTPError not raised

======================================================================
FAIL: test_open_read_not_permitted (tests.test_sftp._TestSFTP)
Test reading data from a file with no read permission

Traceback (most recent call last):
File "/usr/local/poudriere/ports/head/security/py-asyncssh/work-py36/asyncssh-1.14.0/tests/util.py", line 77, in async_wrapper
return self.loop.run_until_complete(wrapped_func)
File "/usr/local/lib/python3.6/asyncio/base_events.py", line 468, in run_until_complete
return future.result()
File "/usr/local/poudriere/ports/head/security/py-asyncssh/work-py36/asyncssh-1.14.0/tests/test_sftp.py", line 77, in sftp_wrapper
yield from asyncio.coroutine(func)(self, sftp)
File "/usr/local/poudriere/ports/head/security/py-asyncssh/work-py36/asyncssh-1.14.0/tests/test_sftp.py", line 1342, in test_open_read_not_permitted
f = yield from sftp.open('file')
AssertionError: SFTPError not raised

======================================================================
FAIL: test_open_read_not_permitted (tests.test_sftp._TestSFTPAsync)
Test reading data from a file with no read permission

Traceback (most recent call last):
File "/usr/local/poudriere/ports/head/security/py-asyncssh/work-py36/asyncssh-1.14.0/tests/util.py", line 77, in async_wrapper
return self.loop.run_until_complete(wrapped_func)
File "/usr/local/lib/python3.6/asyncio/base_events.py", line 468, in run_until_complete
return future.result()
File "/usr/local/poudriere/ports/head/security/py-asyncssh/work-py36/asyncssh-1.14.0/tests/test_sftp.py", line 77, in sftp_wrapper
yield from asyncio.coroutine(func)(self, sftp)
File "/usr/local/poudriere/ports/head/security/py-asyncssh/work-py36/asyncssh-1.14.0/tests/test_sftp.py", line 1342, in test_open_read_not_permitted
f = yield from sftp.open('file')
AssertionError: SFTPError not raised

[ronf]

I'm not seeing these failures here, or either MacOS or Ubuntu. It's also not showing up on TravisCI or AppVeyor, on any of Linux, Mac, and Windows. Which platform are you seeing this on?

Do you get this same set of errors from earlier AsyncSSH releases?

[ndowens]

@ronf yep on 1.12.1 as well

[ndowens]

freebsd

[ronf]

Ok, so it isn't new, but it does seem to be specific to FreeBSD (and maybe other BSD flavors). Unfortunately, I don't have any BSD machines here to test this against. Could you do a bit more digging into the specific tests? They all seem to be related to permissions, so that's probably the place to start. There's really only two tests here -- you're just seeing each of these run twice, once synchronously and once asynchronously.

The specific tests are both quite short:

            self._create_file('file', mode=0)

            with self.assertRaises(SFTPError):
                f = yield from sftp.open('file')

and

            self._create_file('src', mode=0)

            with self.assertRaises(SFTPError):
                yield from scp((self._scp_server, 'src'), 'dst')

I suspect it has to do with the use of "mode=0" in the create_file function, which turns into:

        if mode is not None:
            os.chmod(name, mode)

Perhaps FreeBSD doesn't like chmod() being called with a mode of 0? It seems to be that should be allowed. Can you try and repeat this with a standalone program, such as:

import asyncio, asyncssh, os, sys

async def run_client():
    with open('/tmp/example.txt', 'w') as f:
        f.write('test')

    os.chmod('/tmp/example.txt', 0)

    await asyncssh.scp('localhost:/tmp/example.txt', '/tmp')

try:
    asyncio.get_event_loop().run_until_complete(run_client())
except (OSError, asyncssh.Error) as exc:
    sys.exit('SFTP operation failed: ' + str(exc))

You should see an error such as:

SFTP operation failed: [Errno 13] Permission denied: '/tmp/example.txt'

[ndowens]

I created a file as standalone and it gives
File "test.py", line 4
async def run_client():
^
SyntaxError: invalid syntax

put it inside the tests/ folder

[ronf]

The example uses the new Python async syntax, so you'd need to be on at least Python 3.5. Are you running Python 3.4? If so, you'd need to convert it to use @asyncio.coroutine and "yield from".

[ndowens]

ok using 3.5 no module asyncssh

[ronf]

If you don't have asyncssh installed yet, you'll need to run the example from a place which has a local copy of 'asyncssh' (the one with the actual modules in it, not the one that has the README and setup.py).

[ronf]

If you have a copy of the asyncssh tar file unpacked you can put this example in the same directory as the setup.py.

[ndowens]

SFTP operation failed: Disconnect Error: No trusted server host keys available

[ronf]

You'll need a trusted key for localhost in your .ssh/known_hosts file. You should be able to get that if you just "ssh localhost" by hand and tell it to add the key.

[ndowens]

SFTP operation failed: Disconnect Error: Permission denied

[ronf]

That's closer, but that suggests you are getting the error on the remote system, not the local one, which doesn't seem right here. Try changing the line:

await asyncssh.scp('localhost:/tmp/example.txt', '/tmp')

to:

await asyncssh.scp('localhost:/tmp/example.txt', '/tmp/example2.txt')

[ndowens]

SFTP operation failed: [Errno 13] Permission denied: '/tmp/example.txt'

[ronf]

Ok, so you're able to reproduce the expected error. Given that, I'm not really sure why the tests are failing. They're doing something very similar.