column descriptor deserialisation logic added #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverweed
reviewed
Jun 16, 2025
| else { | ||
| console.log(`OK: ${rntuple.builder.columnDescriptors.length} column(s) deserialized`); | ||
| for (let i = 0; i < rntuple.builder.columnDescriptors.length; ++i) { | ||
| const column = rntuple.builder.columnDescriptors[i]; |
There was a problem hiding this comment.
The tests for both columns and fields should be made more comprehensive (it can be in a separate PR).
E.g, for fields, verify that the field name and types are those that you expect; for columns verify that the field ID and column types are the ones you expect etc.
Does not need to be for every field and column, but at least for the first and last field they should be there. Ideally you should test all the properties of the descriptors.
Co-authored-by: Silverweed <7806878+silverweed@users.noreply.github.com>
linev
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.