v624: Additional fixes for std::pair's StreamerInfo handling #10280

pcanal · 2022-03-30T18:22:36Z

phsft-bot · 2022-03-30T18:22:43Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-03-30T18:58:27Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-03-30T18:58:46Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-03-30T19:24:39Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-03-30T19:32:05Z

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2022-03-30T20:39:26Z

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-03-30T21:31:19Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-03-30T22:22:07Z

Build failed on mac1015/python3.
Running on macitois19.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

smuzaffar · 2022-03-31T06:16:52Z

@pcanal , this now has fixed the failing HLT tests in cmssw.

pcanal · 2022-04-04T21:29:09Z

Thank.

This is done also for multimap.

When encountering a data member of a class that is a enum or if it is use in a map or multimap, record the enum in the rootpcm.

This was a fatal typo in 9678405 pair: properly update StreamerInfo.

We already had TListOfEnumsWithLock but TListOfEnums::FindObject is used by rootcling

In the 'root_serialization' use case, we ended in TBufferFile::WriteClassBuffer with no StreamerInfo created yet for the TClass for `std::vector<float>` and thus go into the branch that creates the StreamerInfo ... However, at least in that case, the call to `BuildRealData` induced the creation of the StreamerInfo but the code in `TBufferFile::WriteClassBuffer` did not notice and thus create a second one and tried to register it in the same slot. (The actual negative side effect was only an error message and a memory leak).

This happened in a user case where the container (map) for a pair of an enum, which had not dictionary and something else that did have a dictionary.

This was happening when, inadvertently, StreamerInfo were created multiple times and then immeditately deleted (for map<enumtype_without_dict, somethinelse>)

phsft-bot · 2022-04-06T00:22:41Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-04-06T01:15:51Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-04-06T01:37:23Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-3.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-04-06T02:01:46Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-04-06T02:22:11Z

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2022-04-06T03:07:09Z

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-04-06T04:22:05Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-04-06T05:33:44Z

Build failed on mac1015/python3.
Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-04-06T12:37:30Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-04-06T13:02:41Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-04-06T13:15:04Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-3.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-04-06T13:26:34Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-04-06T14:19:30Z

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-04-06T14:21:27Z

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2022-04-06T14:43:40Z

Build failed on mac1015/python3.
Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

phsft-bot · 2022-04-06T15:39:28Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_runforeign

pcanal requested a review from Axel-Naumann as a code owner March 30, 2022 18:22

pcanal mentioned this pull request Mar 30, 2022

failure of HLT-Validation tests in reading edm::HepMCProduct cms-sw/cmssw#37392

Closed

Axel-Naumann assigned pcanal Apr 4, 2022

pcanal added in:Core Libraries in:I/O affects:6.24 pr:backport priority:critical labels Apr 6, 2022

pcanal added 12 commits April 5, 2022 19:19

rootpcm: Read enums before class to get the correct underlying type.

1a1fb79

When loading a TClass for map, also update the pair's TClass.

fe0b4ce

This is done also for multimap.

TStreamerInfo::Clear, also reset TStreamerElement's offset

bed6557

rootcling: record Enum used by classes and collection.

8a79a4a

When encountering a data member of a class that is a enum or if it is use in a map or multimap, record the enum in the rootpcm.

io: Correct offset passed from SyntheticPair to StreamerInfo.

3c5fa3d

This was a fatal typo in 9678405 pair: properly update StreamerInfo.

Add missing TListOfEnums::FindObject.

01e58c7

We already had TListOfEnumsWithLock but TListOfEnums::FindObject is used by rootcling

TGenCollectionProxy: add missing nullptr protection

f972463

When resetting a pair's StreamerInfo inform all collection proxies

dd8ccca

TProtoClass::FillTClass: Create a ListEnumsWithLock when needed

7e37d73

Don't put class' enum in rootpcm global list of enums

9c6129c

pair: Also treat unordered map

a0c9807

TClass: clear fLastReadInfo, fCurrentInfo when deleting TStreamerInfos

c982d6f

pcanal added 5 commits April 5, 2022 19:20

Do the pair TClass StreamerInfo refresh only when needed

84a00aa

TGenCollectionProxy init: fail if the value's StreamerInfo is not there.

260355c

This happened in a user case where the container (map) for a pair of an enum, which had not dictionary and something else that did have a dictionary.

Avoid reading pass the end of the StreamerInfo container.

44bef95

This was happening when, inadvertently, StreamerInfo were created multiple times and then immeditately deleted (for map<enumtype_without_dict, somethinelse>)

CollectionProxy: pass pair hint to R__CreateValue

d36536d

pcanal force-pushed the v624-issue-10131 branch from 6061468 to d36536d Compare April 6, 2022 00:22

pcanal added 2 commits April 6, 2022 07:37

Remove unnecessary trailing semi-colon

a5a3b05

[NFC] Simplify code in TListOfEnums

c8a1283

pcanal merged commit 3c21b04 into root-project:v6-24-00-patches Apr 6, 2022

v624: Additional fixes for std::pair's StreamerInfo handling #10280

v624: Additional fixes for std::pair's StreamerInfo handling #10280

Uh oh!

Conversation

pcanal commented Mar 30, 2022

Uh oh!

phsft-bot commented Mar 30, 2022

Uh oh!

phsft-bot commented Mar 30, 2022

Failing tests:

Uh oh!

phsft-bot commented Mar 30, 2022

Failing tests:

Uh oh!

phsft-bot commented Mar 30, 2022

Failing tests:

Uh oh!

phsft-bot commented Mar 30, 2022

Failing tests:

Uh oh!

phsft-bot commented Mar 30, 2022

Failing tests:

Uh oh!

phsft-bot commented Mar 30, 2022

Failing tests:

Uh oh!

phsft-bot commented Mar 30, 2022

Failing tests:

Uh oh!

smuzaffar commented Mar 31, 2022

Uh oh!

pcanal commented Apr 4, 2022

Uh oh!

phsft-bot commented Apr 6, 2022

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

phsft-bot commented Apr 6, 2022

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

phsft-bot commented Apr 6, 2022

Failing tests:

Uh oh!

Reviewers