-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Improve GetColorTransparent. #10314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GetColorTransparent. #10314
Conversation
Starting build on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after fixing the clang-format report
Starting build on |
Build failed on ROOT-debian10-i386/cxx14. Errors:
|
Build failed on ROOT-performance-centos8-multicore/default. Errors:
|
Build failed on ROOT-ubuntu2004/soversion. Errors:
|
Build failed on mac1015/python3. Errors:
|
Build failed on mac11/cxx17. Errors:
|
* Improve GetColorTransparent. * Coding conventions
As pointed in this issue #10299, a new color was defined each time a transparent color (with alpha channel) was requested. This PR fixes that by checking if a similar transparent color exists.