Skip to content

Conversation

couet
Copy link
Member

@couet couet commented Apr 4, 2022

As pointed in this issue #10299, a new color was defined each time a transparent color (with alpha channel) was requested. This PR fixes that by checking if a similar transparent color exists.

@couet couet requested a review from bellenot April 4, 2022 08:18
@couet couet self-assigned this Apr 4, 2022
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after fixing the clang-format report

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@couet couet merged commit 24505fc into root-project:master Apr 4, 2022
@phsft-bot
Copy link

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-04-04T13:25:17.174Z] stderr: error: Failed to merge in the changes.
  • [2022-04-04T13:25:22.231Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-04-04T15:07:18.411Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-04-04T15:23:07.876Z] stderr: error: Failed to merge in the changes.
  • [2022-04-04T15:23:13.026Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

@phsft-bot
Copy link

Build failed on mac1015/python3.
Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-04-04T18:55:46.572Z] stderr: error: Failed to merge in the changes.
  • [2022-04-04T18:55:52.273Z] CMake Error at /Volumes/HD2/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

@phsft-bot
Copy link

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-04-04T21:01:51.521Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

@couet couet deleted the improve-GetColorTransparent branch April 5, 2022 13:16
Neel-Shah-29 pushed a commit to Neel-Shah-29/root-1 that referenced this pull request Apr 6, 2022
* Improve GetColorTransparent.

* Coding conventions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants