[RF] Fix normalization issues with RooGenericPdf and RooFormulaVar #10873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a normalization set within `evaluate()`, the RooGenericPdf used the `RooAbsPdf::_normSet` member, and the RooFormulaVar used the `RooAbsReal::_lastNSet` member. Both of them are not supposed to be used outside the implementation of `RooAbsPdf::getValV()` and `RooAbsReal::getValV()` and they are unreliable in any other context. Actually, in `evaluate()`, one should always use the normalization set from the proxy, which is in this case a RooArgList (see for example how the RooAddition does it). This commit suggests to do that for the RooGenericPdf and RooFormulaVar. This change fixes the following Jira issue: [ROOT-5101](https://sft.its.cern.ch/jira/browse/ROOT-5101) A new unit test is implemented in `testGenericPdf` to cover the problem reported in that issue.
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Failing tests: |
|
Failures on centos8 are all unrelated to this PR, but related to the known issue with |
This was referenced Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a normalization set within
evaluate(), the RooGenericPdf used theRooAbsPdf::_normSetmember, and the RooFormulaVar used theRooAbsReal::_lastNSetmember. Both of them are not supposed to be usedoutside the implementation of
RooAbsPdf::getValV()andRooAbsReal::getValV()and they are unreliable in any other context.Actually, in
evaluate(), one should always use the normalization setfrom the proxy, which is in this case a RooArgList (see for example how
the RooAddition does it). This commit suggests to do that for the
RooGenericPdf and RooFormulaVar.
This change fixes the following Jira issue:
ROOT-5101
A new unit test is implemented in
testGenericPdfto cover the problemreported in that issue.