[cxxmodules] Multiplex the ExternalASTSource in cling #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to respect the existing ExternalASTSource when setting up the interpreter. Otherwise the ASTReader (which is the existing source) doesn't receive the required callbacks to properly load C++ modules. This patch now creates a multiplexer that contains our new ASTSource and the existing one if it's necessary. We also no longer attach the existing sema source which seemingly was only a workaround that only works for the special case were the external sema source and the external AST source are the same object.
|
Starting build on |
|
Build failed on windows10/vc15. |
|
@phsft-bot build with flags -Druntime_cxxmodules=On |
|
Starting build on |
|
Build failed on centos7/gcc49. Errors:
And 10 more Warnings:
And 6 more |
|
Build failed on slc6/gcc49. Errors:
And 10 more Warnings:
And 6 more |
|
Build failed on slc6/gcc62. Errors:
And 10 more Warnings:
And 6 more |
|
Build failed on slc6/gcc62. Errors:
And 10 more Warnings:
And 6 more |
|
Build failed on ubuntu14/native. Errors:
And 10 more Warnings:
And 6 more |
|
Build failed on ubuntu14/native. Errors:
And 10 more Warnings:
And 6 more |
|
Build failed on mac1012/native. |
|
@phsft-bot build -Dvc=OFF -Dimt=ON -Dccache=ON |
|
Starting build on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to respect the existing ExternalASTSource when setting up the
interpreter. Otherwise the ASTReader (which is the existing source)
doesn't receive the required callbacks to properly load C++ modules.
This patch now creates a multiplexer that contains our new
ASTSource and the existing one if it's necessary. We also
no longer attach the existing sema source which seemingly
was only a workaround that only works for the special case
were the external sema source and the external AST source
are the same object.