Skip to content

Conversation

etejedor
Copy link
Collaborator

Introduce MT testing for the TDataFrame with friends scenario.

@etejedor etejedor requested a review from pcanal as a code owner November 10, 2017 14:20
@etejedor etejedor requested review from dpiparo and eguiraud November 10, 2017 14:20
@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@eguiraud
Copy link
Contributor

Thank you a lot!! Is it worth to also test the friends-of-friends case?

@etejedor
Copy link
Collaborator Author

I'm afraid friends of friends are not supported in TTreeProcessorMT itself. I was not aware of this use case, this means that when I read a tree I can also see the branches of the friends of the friends (of the friends of the friends etc.) of that tree?

@phsft-bot
Copy link

Build failed on centos7/gcc49.
See console output.

Errors:

  • ERROR: Error fetching remote repo 'origin'
  • stderr: error: RPC failed; result=18, HTTP code = 200
  • ERROR: Error fetching remote repo 'origin'

Warnings:

  • ../root/roofit/roofit/src/RooMomentMorphFuncND.cxx:439:32: warning: declaration of ‘offset’ shadows a member of 'this' [-Wshadow]
  • ../root/roofit/roofit/src/RooMomentMorphFuncND.cxx:824:9: warning: variable ‘isEnclosed’ set but not used [-Wunused-but-set-variable]

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Errors:

  • ERROR: Timeout after 10 minutes
  • ERROR: Error fetching remote repo 'origin'
  • stderr: error: RPC failed; result=18, HTTP code = 200
  • ERROR: Error fetching remote repo 'origin'

Warnings:

  • ../root/roofit/roofitcore/src/RooRealSumFunc.cxx:354:13: warning: unused variable ‘code2’ [-Wunused-variable]
  • ../root/roofit/roofit/src/RooMomentMorphFuncND.cxx:824:9: warning: variable ‘isEnclosed’ set but not used [-Wunused-but-set-variable]

@phsft-bot
Copy link

Build failed on windows10/vc15.
See console output.

Errors:

  • ERROR: Error fetching remote repo 'origin'
  • error: RPC failed; curl 18 transfer closed with outstanding read data remaining
  • ERROR: Error fetching remote repo 'origin'

@phsft-bot
Copy link

Build failed on slc6/gcc49.
See console output.

Errors:

  • ERROR: Timeout after 10 minutes
  • ERROR: Error fetching remote repo 'origin'
  • stderr: error: RPC failed; result=18, HTTP code = 200
  • ERROR: Error fetching remote repo 'origin'

Warnings:

  • ../root/roofit/roofit/src/RooMomentMorphFuncND.cxx:439:32: warning: declaration of ‘offset’ shadows a member of 'this' [-Wshadow]
  • ../root/roofit/roofit/src/RooMomentMorphFuncND.cxx:824:9: warning: variable ‘isEnclosed’ set but not used [-Wunused-but-set-variable]

@etejedor etejedor merged commit d8a8c9e into root-project:master Nov 10, 2017
@phsft-bot
Copy link

Build failed on ubuntu14/native.
See console output.

@pcanal
Copy link
Member

pcanal commented Nov 10, 2017

I'm afraid friends of friends are not supported in TTreeProcessorMT itself. I was not aware of this use case, this means that when I read a tree I can also see the branches of the friends of the friends (of the friends of the friends etc.) of that tree?

Yes.

@dpiparo
Copy link
Member

dpiparo commented Nov 12, 2017

I propose to document this feature clearly unless it can be easily implemented. Technically it's a bug fix, I do not see issues in dealing with it for 6.12 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants