[RF] Fix creating yield histograms from extended pdfs #17170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 18 files 18 suites 4d 14h 5m 35s ⏱️ For more details on these failures, see this check. Results for commit b9f8fed. ♻️ This comment has been updated with latest results. |
When using the `Extended()` keyword argument in `createHistogram()` the docs say it has the following effect: > Plot event yield instead of probability density (for extended pdfs only) However, to get yields out of the probability densities, one has to not only multiply with the total number of expected events, but also with the bin volumes. I don't understand why the bin volume multiplication is disable in *exactly* this case. This commit suggests to not do that anymore, in order to be able to correctly produce predicted yields histograms. Thanks to the following forum post for noticing this: https://root-forum.cern.ch/t/bin-content-of-pdf-and-generated-data/62370 This change of behavior is also mentioned in the release notes. A unit test to validate that the yield histogram can now be correctly created is also added.
guitargeek
changed the title
lmoneta
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
Extended()keyword argument increateHistogram()thedocs say it has the following effect:
However, to get yields out of the probability densities, one has to not
only multiply with the total number of expected events, but also with
the bin volumes. I don't understand why the bin volume multiplication is
disable in exactly this case. This commit suggests to not do that
anymore, in order to be able to correctly produce predicted yields
histograms.
Thanks to the following forum post for noticing this:
https://root-forum.cern.ch/t/bin-content-of-pdf-and-generated-data/62370
This change of behavior is also mentioned in the release notes.
A unit test to validate that the yield histogram can now be correctly
created is also added.