[math][genvector] add support for structured bindings in 2D/3D/4D #19956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdymercury
force-pushed
the
structbin
branch
from
accffc8 to
af3c956
Compare
|
@ferdymercury, thank you very much, this is amazing! Could you fix the build errors on e.g. |
|
I do not know how to fix the remaining failure :S |
ferdymercury
force-pushed
the
structbin
branch
from
3aa78c4 to
0d0513e
Compare
ferdymercury
force-pushed
the
structbin
branch
from
0d0513e to
1e39da2
Compare
…ntzVector [genvectorx] try namespace cleanup [math] remove redundant std qualifier that is problematic on some compilers [math] rm redundant namespace confusing compiler [math] fix namespace confusion [math] missing header [math] missing headers [nfc] document structured bindings as alternative
ferdymercury
force-pushed
the
structbin
branch
from
1e39da2 to
06d98b4
Compare
ferdymercury
force-pushed
the
structbin
branch
4 times, most recently
from
3447b5f to
903be4f
Compare
ferdymercury
force-pushed
the
structbin
branch
from
903be4f to
9372f85
Compare
|
Giving up on the SYCL part... @devajithvs feel free to backport it to genvectorX if you find out how to do it, I couldn't... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes #11806
Credit goes to @knoepfel
Checklist: