Fix TH2 and TH3 arithmetic operators in Python #20029
Merged
+205
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siliataider
force-pushed
the
th_op_plus
branch
from
a82e882 to
95443e2
Compare
siliataider
changed the title
siliataider
requested review from
lmoneta,
dpiparo and
vepadulano
as code owners
siliataider
force-pushed
the
th_op_plus
branch
from
95443e2 to
4b0a50c
Compare
ferdymercury
reviewed
Oct 3, 2025
siliataider
force-pushed
the
th_op_plus
branch
from
4b0a50c to
8290fe7
Compare
vepadulano
approved these changes
Oct 3, 2025
Test Results 22 files 22 suites 3d 15h 58m 37s ⏱️ Results for commit f5d10bd. ♻️ This comment has been updated with latest results. |
ferdymercury
approved these changes
Oct 4, 2025
siliataider
force-pushed
the
th_op_plus
branch
from
4abac9b to
f5d10bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
The operators for
TH2*andTH3*were declared only as friend functions inside the class, without matching free-function declarations in the header, which prevented them from being picked up in BuildScopeProxyDict and therefore could not be exposed in Python.This PR adds the missing free-function declarations for
TH2*andTH3*operators ensuring that the proper Python bindings are generated.Checklist:
This PR fixes #20014