Skip to content

Conversation

aviralgarg05
Copy link

This Pull request:

Changes or fixes:

  • Add import functools to enable metadata preservation
  • Decorate wrapper function with @functools.wraps(original_init) to maintain name, doc, and wrapped attributes
  • Fixes TColor.DefinedColors(1) failure in Jupyter notebooks
  • Ensures proper method resolution in introspection-heavy environments

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #20018

Copy link

github-actions bot commented Oct 7, 2025

Test Results

    22 files      22 suites   3d 20h 32m 52s ⏱️
 3 692 tests  3 673 ✅  1 💤 18 ❌
79 286 runs  79 119 ✅ 93 💤 74 ❌

For more details on these failures, see this check.

Results for commit c72f0e0.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo assigned linev and guitargeek and unassigned linev Oct 8, 2025
@dpiparo dpiparo requested a review from guitargeek October 8, 2025 05:00
@dpiparo
Copy link
Member

dpiparo commented Oct 8, 2025

Thanks for this code. In order to start the review we would need to also have a test that reproduces the problem. Notebook tests are in this directory https://github.com/root-project/root/tree/master/roottest/python/JupyROOT

@aviralgarg05 aviralgarg05 requested a review from bellenot as a code owner October 8, 2025 08:01
@aviralgarg05 aviralgarg05 force-pushed the fix/tcolor-preserve-metadata branch from a4fcac7 to 126b87a Compare October 9, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ROOT.TColor.DefinedColors(1) problematic in jupyter notebooks

4 participants