Skip to content

[RF] Enable I/O for RooNDKeysPdf #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2020
Merged

[RF] Enable I/O for RooNDKeysPdf #4741

merged 2 commits into from
Jan 9, 2020

Conversation

hageboeck
Copy link
Member

[ROOT-10341] To enable serialisation, several members of RooNDKeysPdf
had to be removed or their type had to be changed. A few members
cannot be serialised and therefore have to be recomputed when necessary.
Some first cleaning up was also done.

@hageboeck hageboeck requested a review from lmoneta January 8, 2020 17:04
@hageboeck hageboeck self-assigned this Jan 8, 2020
@hageboeck hageboeck added this to the 6.20 milestone Jan 8, 2020
@phsft-bot
Copy link

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-performance-centos7-multicore/default.
See console output.

Warnings:

  • /data/sftnight/workspace/root-pullrequests-build/root/roofit/roofitcore/inc/RooTemplateProxy.h:54:3: warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]
  • /data/sftnight/workspace/root-pullrequests-build/root/roofit/roofitcore/inc/RooTemplateProxy.h:62:85: warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]
  • /data/sftnight/workspace/root-pullrequests-build/root/roofit/roofitcore/inc/RooTemplateProxy.h:68:87: warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]
  • /data/sftnight/workspace/root-pullrequests-build/root/roofit/roofitcore/inc/RooTemplateProxy.h:61:3: warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]
  • /data/sftnight/workspace/root-pullrequests-build/root/roofit/roofitcore/inc/RooTemplateProxy.h:68:3: warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]
  • /data/sftnight/workspace/root-pullrequests-build/root/roofit/roofitcore/inc/RooTemplateProxy.h:68:3: warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]
  • /data/sftnight/workspace/root-pullrequests-build/root/roofit/roofitcore/inc/RooTemplateProxy.h:68:3: warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]
  • /data/sftnight/workspace/root-pullrequests-build/root/roofit/roofitcore/inc/RooTemplateProxy.h:68:3: warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]
  • /data/sftnight/workspace/root-pullrequests-build/root/roofit/roofitcore/inc/RooTemplateProxy.h:54:3: warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]
  • /data/sftnight/workspace/root-pullrequests-build/root/roofit/roofitcore/inc/RooTemplateProxy.h:62:85: warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]

And 843 more

@phsft-bot
Copy link

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

@hageboeck
[RF] Enable serialisation of RooNDKeysPdf.
848917a 
[ROOT-10341] To enable serialisation, several members of RooNDKeysPdf
had to be removed or their type had to be changed. A few members
cannot be serialised and therefore have to be recomputed when necessary.
Some first cleaning up was also done.
@hageboeck
[RF] Modernise loops in RooChangeTracker.
810beb3
@phsft-bot
Copy link

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

@hageboeck hageboeck merged commit 8630a93 into root-project:master Jan 9, 2020
@hageboeck hageboeck deleted the NDKeysIO branch January 9, 2020 15:29
@phsft-bot
Copy link

Build failed on ROOT-ubuntu18.04-i386/cxx14.
See console output.

Errors:

  • CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:869 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

@couet couet Awaiting requested review from couet

@oshadura oshadura Awaiting requested review from oshadura

Assignees

@hageboeck hageboeck

Labels
None yet
Projects
None yet
Milestone
6.20
Development

Successfully merging this pull request may close these issues.
2 participants
@hageboeck @phsft-bot