FIX issue #7212: TMathText does not display with high value coordinates #7233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
couet
requested review from
bellenot
and removed request for
Axel-Naumann and
pcanal
bellenot
requested changes
Feb 17, 2021
|
Starting build on |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Errors:
|
bellenot
approved these changes
Feb 17, 2021
|
Build failed on ROOT-performance-centos8-multicore/default. Errors:
|
|
Build failed on ROOT-fedora30/cxx14. Errors:
And 16 more |
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/default. Errors:
|
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/default. Errors:
|
|
Build failed on ROOT-fedora30/cxx14. Errors:
And 16 more |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Errors:
|
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Errors:
|
|
Build failed on ROOT-performance-centos8-multicore/default. Errors:
|
|
Build failed on ROOT-fedora31/noimt. Errors:
|
|
Build failed on ROOT-fedora30/cxx14. Errors:
And 10 more |
|
Starting build on |
|
Hi, |
|
Or one can use |
nicknagi
pushed a commit
to nicknagi/root
that referenced
this pull request
Mar 30, 2021
…ue coordinates (root-project#7233) * FIX issue root-project#7212: TMathText does not display with high value coordinates * Use INT_MAX * add missing include and fix typos * INT_MAX seems to be very machine dependant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #7212.
The TMathText method GetAlignPoint() computes the offset required to implement the text alignment. It does it using
integers (pixels). The value of kMaxPixel was arbitrary fixed to 32000.
In case of very high range in user coordinates the TMathText position was wrong. There is no reason to fix the kMaxPixel arbitrary to 32000. We can go to the maximal possible integer. That's what this fix is implementing. Doing that the issue #7212 is fixed.