Skip to content

[RF] Fix size of output span from RooUniform::evaluateSpan() #8733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2021
Merged

[RF] Fix size of output span from RooUniform::evaluateSpan() #8733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion roofit/roofit/src/RooUniform.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,14 @@ RooSpan<double> RooUniform::evaluateSpan(RooBatchCompute::RunContext& evalData,
{
size_t nEvents = 1;
for (auto elm : x) {
nEvents *= static_cast<const RooAbsReal*>(elm)->getValues(evalData).size();
size_t nEventsCurrent = static_cast<const RooAbsReal*>(elm)->getValues(evalData).size();
if(nEventsCurrent != 1 && nEvents != 1 && nEventsCurrent != nEvents) {
auto errorMsg = std::string("RooUniform::evaluateSpan(): number of entries for input variables does not match")
+ "in RooUniform with name \"" + GetName() + "\".";
coutE(FastEvaluations) << errorMsg << std::endl ;
throw std::runtime_error(errorMsg);
}
nEvents = std::max(nEvents, nEventsCurrent);
}
RooSpan<double> values = evalData.makeBatch(this, nEvents);
for (size_t i=0; i<nEvents; i++) {
Expand Down