Skip to content

Fixes for existing benchmarks #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 14, 2017
Merged

Fixes for existing benchmarks #16

merged 6 commits into from
Nov 14, 2017

Conversation

oshadura
Copy link
Contributor

@oshadura oshadura commented Nov 7, 2017

  • GenVectorBenchmark is disabled: on-going fixes on GenVector side

@oshadura oshadura changed the title Root bench fixes for existing benchmarks Fixes for existing benchmarks Nov 7, 2017
vgvassilev
vgvassilev reviewed Nov 7, 2017
View reviewed changes
Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general we should not have standalone clang-format commits...

root/io/io/TBufferMergerBenchmarks.cxx
auto f = merger.GetFile();
auto t = new TTree("random", "random");
t->ResetBit(kMustCleanup);
t->SetAutoFlush(-(flush) * 1024 * 1024); // Flush at exceeding 32MB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, I didn't recheck after clang-format, it is because of "pointer-like" behavior?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 990c7df on oshadura:root-bench-fix into 3bf86f0 on root-project:master.

@coveralls
Copy link

coveralls commented Nov 8, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 0.0% when pulling f0ec762 on oshadura:root-bench-fix into 3bf86f0 on root-project:master.

@oshadura
Copy link
Contributor Author

oshadura commented Nov 8, 2017

IO benchmark is randomly failing, I think I need to take a look maybe..

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 6ec7112 on oshadura:root-bench-fix into 3bf86f0 on root-project:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 3afff80 on oshadura:root-bench-fix into 3bf86f0 on root-project:master.

@coveralls
Copy link

coveralls commented Nov 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 0.0% when pulling 762c519 on oshadura:root-bench-fix into 3bf86f0 on root-project:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 4cae9a8 on oshadura:root-bench-fix into 3bf86f0 on root-project:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling a919780 on oshadura:root-bench-fix into 3bf86f0 on root-project:master.

@oshadura oshadura merged commit 02e5a2a into root-project:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgvassilev vgvassilev vgvassilev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oshadura @coveralls @vgvassilev