Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Gitlab CI/CD section #943

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bellenot
Copy link
Member

@bellenot bellenot commented Dec 7, 2023

No description provided.

@bellenot bellenot self-assigned this Dec 7, 2023
Copy link
Member

@couet couet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

install/index.md Outdated

# Using ROOT in Gitlab CI/CD

Here is an example on how to add ROOT into a Gitlab CI/CD from CVMFS, provided by one of our user on the [ROOT Forum](https://root-forum.cern.ch/t/gitlab-ci-using-root/57375/9):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Here is an example on how to add ROOT into a Gitlab CI/CD from CVMFS, provided by one of our user on the [ROOT Forum](https://root-forum.cern.ch/t/gitlab-ci-using-root/57375/9):
Here is an example on how to add ROOT into a Gitlab CI/CD from CVMFS, provided by one of our users on the [ROOT Forum](https://root-forum.cern.ch/t/gitlab-ci-using-root/57375/9):

install/index.md Show resolved Hide resolved
install/index.md Outdated Show resolved Hide resolved
@bellenot
Copy link
Member Author

bellenot commented Dec 7, 2023

@xkzl can you address the reviewer comments?

@meiyasan
Copy link

meiyasan commented Dec 7, 2023

@xkzl can you address the reviewer comments?

@bellenot some issues pushing through your fork

$ git push
remote: Permission to bellenot/web.git denied to xkzl.
fatal: unable to access 'https://github.com/bellenot/web.git/': The requested URL returned error: 403

@bellenot
Copy link
Member Author

bellenot commented Dec 7, 2023

@bellenot some issues pushing through your fork

$ git push
remote: Permission to bellenot/web.git denied to xkzl.
fatal: unable to access 'https://github.com/bellenot/web.git/': The requested URL returned error: 403

You can either suggest changes via the web interface, or post a diff, or a complete updated example. As you prefer

@meiyasan
Copy link

meiyasan commented Dec 7, 2023

Here is the update I can offer.

# ROOT in Gitlab CI/CD (CERN)

Below are practical examples demonstrating how to integrate ROOT into a GitLab CI/CD instance, provided by one of our users on the [ROOT Forum](https://root-forum.cern.ch/t/gitlab-ci-using-root/57375/9).

## Using CVMFS

```yml
#image:

your_task:
stage: build
script:
- echo "CERN CVMFS repository"
- ls -ls /cvmfs/sft.cern.ch/lcg/app/releases/
tags:
- cvmfs
```

## Using Docker containers

```yml
image: rootproject/root:latest

your_task:
stage: build
script:
- echo -ne "ROOT Version "
- which root
- echo "ROOT Features"
- root-config --features
```

@bellenot
Copy link
Member Author

bellenot commented Dec 7, 2023

Thanks @xkzl ! Committed

@Axel-Naumann
Copy link
Member

We need input from @martamaja10 / @vepadulano here - for me, showing these files is questionable because they basically just say "you can use cvmfs or rootproject/root:latest"; for the latter we already have https://root.cern/install/#run-in-a-docker-container

@martamaja10
Copy link
Contributor

I think the use case is slightly different than just running ROOT purely from the Docker container, so I don't see why we shouldn't add it if it would spare some users installation time. I would maybe move it above the "from source" description as it would flow better to have all the docker/cvmfs together and the" from source" section at the end as it was?

@Axel-Naumann Axel-Naumann removed their request for review December 14, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants