add TDD realization to tree data structure #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootTheLure
requested changes
Jun 12, 2019
| it('Should set key, value to root if root is null', function() { | ||
| const tree = new Tree(); | ||
| tree.insert('elem1', 1); | ||
| expect(tree.root.key).to.be.equal('elem1'); |
There was a problem hiding this comment.
better to use number key and not string
| tree.insert(1, 'elem6') | ||
| expect(tree.root.right.left.key).to.be.equal(1); | ||
| expect(tree.root.right.left.key).to.be.equal('elem6'); | ||
| }); |
There was a problem hiding this comment.
3 redundant tests. better to separate them onto 3 with more descriptive names and scenarios.
| tree.delete(5); | ||
| expect(tree.search('elem4')).to.be.throw(ReferenceError, 'This tree doesn\'t contain search value'); | ||
| }); | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check please my TDD workshop.