Add tests for Queue #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootTheLure
requested changes
Jun 12, 2019
| let queue = new Queue(data.n); | ||
| queue.push(...data.test); | ||
|
|
||
| expect(queue.queue).to.be.equal(data.result); |
There was a problem hiding this comment.
- no assertions in the loop
- looks like overkill
| }); | ||
| }); | ||
|
|
||
| it('should add more values, then queue max size', function () { |
| queue.push(...data.test); | ||
|
|
||
| expect(queue.queue, 'should be reduced to queue max size').to.be.equal(data.result); | ||
| }); |
There was a problem hiding this comment.
the same issue as tests above
| let queue = new Queue(0); | ||
| queue.push(1, 2, 3); | ||
|
|
||
| expect(queue.queue).to.be.an('error'); |
|
|
||
| expect(queue.pop(data.n)).to.be.equal(data.result); | ||
| }); | ||
| }); |
| queue.queue = [...data.test]; | ||
|
|
||
| expect(queue.pop(data.n)).to.be.equal(data.result); | ||
| }); |
| queue.queue = [...data.test]; | ||
|
|
||
| expect(queue.top()).to.be.equal(data.result); | ||
| }); |
| queue3 = [...data.queue1, ...data.queue2]; | ||
|
|
||
| expect(queue1.merge(queue1, false)).to.be.equal(queue3); | ||
| }); |
| expect(queue1.merge(queue1, false)).to.be.equal(queue3); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
most of the tests are testing the same logic several times that is not needed, while some functionality is not covered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.