🐛 Fix exception thrown in subfolders and malformed paths (Fixes #355)

[Log1x]

This hopefully fixes all the issues related to routing from the v4 release.

Change log

• 🐛 Fix exception thrown in subfolders and malformed paths (Fixes Admin pages are broken in multisite with subfolder structure #355)
• 🩹 Fix canonical redirects on the WordPress REST route
• 🎨 Add missing types to Bootloader methods
• 🎨 Utilize the app property in Bootloader methods/properties
• 🎨 Clean up storage directory separators
• 🧑‍💻 Properly exclude filtered admin, login, and registration URLs from routing
• 🧑‍💻 Improve checking against the WordPress REST route
• 🧑‍💻 Bail on routing when route is a direct .php file
• 🚩 Remove the experimental request handler flag
  • This needs more testing[1] but I do not want it holding up this PR.

[QWp6t]

LGTM!

[oxyc]

I can confirm this fixes the exception thrown on URLs like /tuote/leitenberger-rfm-03_%AB-refraktometri-adblue-urealiuokselle/

[oxyc]

Actually this introduces another bug where a cookie I used to set on a POST request during wp_loaded doesnt get set if WC sets wp_woocommerce_session_X later. If wp_woocommerce_session_X already exists (so on triggering twice) it sets it.

[Log1x]

Actually this introduces another bug where a cookie I used to set on a POST request during wp_loaded doesnt get set if WC sets wp_woocommerce_session_X later

Do you have an easy way I could test/reproduce this?

[Log1x]

I added back the ACORN_ENABLE_EXPERIMENTAL_WORDPRESS_REQUEST_HANDLER flag for enabling WordPress request handling until I can reproduce/fix this. I do not want it holding up this PR as it has other important fixes (#355) and the request implementation as-is (with flag) is broken entirely.

[oxyc]

It's reproducible with:

add_action('wp_loaded', function () {
    setcookie('test1', 1, [
        'expires' => 0,
        'secure' => true,
        'path' => COOKIEPATH ? COOKIEPATH : '/',
        'domain' => COOKIE_DOMAIN,
    ]);
    setcookie('test2', 1, [
        'expires' => 0,
        'secure' => true,
        'path' => COOKIEPATH ? COOKIEPATH : '/',
        'domain' => COOKIE_DOMAIN,
    ]);
});

Only second cookie gets added. Guess the Set-Cookie header just gets overridden

[QWp6t]

I got a fix implemented for the cookie issue.

Response::header() takes a third parameter to indicate whether it should replace any existing headers with the same key.

class Response {
    public function header($key, $values, $replace = true)
}

I still replace by default, unless the header is Set-Cookie.

                    $response->header($header, $value, $header !== 'Set-Cookie');

So we effectively allow multiple Set-Cookie headers to be sent.

[oxyc]

Fix works for me, E2E tests passing again.