Unit tests

[wolfgangschaefer]

As mentioned in #1 I will add more unit tests to the code.

Tests added for following namespaces:

• Roots\Acorn\Assets
• Roots\Acorn\Clover
• Roots\Acorn\Exceptions

I made as little changes to the code base as possible, I will document them here:

• Added ext-json to composer.json as JsonSerializable was in use
• Added <directory>./tests</directory> to whitelist in phpunit.xml.dist to correctly calculate coverage
• Removed unused Roots\Acorn\Assets\RelativePathManifest and fixed type hints in AssetManager.php
• Fixed types RelativePathManifest.php and added missing array initialization
• Fixed type in Acorn/Bootstrap/LoadBindings.php
• Added missing dependency to illuminate/http and fixed type hint in Acorn/Exceptions/Handler.php render method

[Log1x]

Really appreciate you jumping in to work on this.

[wolfgangschaefer]

In SageTest there are a couple of unit tests marked incomplete:

    /** @test */
    public function it_should_compile_list_of_theme_templates()
    {
        $this->markTestIncomplete();
    }

    /** @test */
    public function it_should_share_the_loop_post_with_view()
    {
        $this->markTestIncomplete();
    }

    /** @test */
    public function it_should_load_data_based_on_body_class()
    {
        $this->markTestIncomplete();
    }

I don't understand what exactly should be tested. But I would like to complete them ;)
Originally they were contributed by @QWp6t - Maybe someone can explain what should be tested here?

Another question I had in mind was if I could have a look at Clover itself. It would give me better insight into how Clover and Acorn work together. I could not find Clover in Roots repositories.

This week the PR will be ready for review. I am only missing the View namespace.

[QWp6t]

Thanks again for your contributions. 🙌

We've added a lot more to Sage since I added those empty tests, but here are links to what I was intending to test:

• it_should_compile_list_of_theme_templates
• it_should_share_the_loop_post_with_view
• it_should_load_data_based_on_body_class

[wolfgangschaefer]

Added the tests that were marked incomplete and opened the PR for review.

[QWp6t]

Thanks for all the work you put into this! 🙏