Skip to content

Add parallel gem #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2023
Merged

Add parallel gem #393

merged 1 commit into from
Aug 15, 2023

Conversation

grosendo2006
Copy link
Contributor

@grosendo2006 grosendo2006 commented Jul 31, 2023 •
edited by lauperalti
Loading

Description:

Add parallel gem to improve CI

@grosendo2006 grosendo2006 force-pushed the add-parell-test branch 3 times, most recently from d860da5 to e6673cb Compare July 31, 2023 21:34
@grosendo2006 grosendo2006 changed the base branch from main to release/improve-ci August 1, 2023 18:38
@grosendo2006 grosendo2006 marked this pull request as ready for review August 1, 2023 18:38
megatux
megatux reviewed Aug 1, 2023
View reviewed changes
config/database.yml.example
test:
<<: *default
database: sample_project_test
database: sample_project_test<%= ENV['TEST_ENV_NUMBER'] %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this change in the db name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@megatux this is part of adding this gem, and also we're going to merge this and other PRs into a release branch, so when we have the functionality working as expected we'll create a new PR to merge against main. That works for you?

@grosendo2006 grosendo2006 removed the WIP label Aug 8, 2023
santib
santib reviewed Aug 8, 2023
View reviewed changes
santib
santib reviewed Aug 8, 2023
View reviewed changes
@santib
Copy link
Member

santib commented Aug 8, 2023

Will te integration with the CI and with knapsack be done as part of this PR?

@grosendo2006
Copy link
Contributor Author

Will te integration with the CI and with knapsack be done as part of this PR?

@santib this is part of adding this gem, and also we're going to merge this and other PRs (integration with the CI and with knapsack) into a release branch, so when we have the functionality working as expected we'll create a new PR to merge against main. That works for you?

@grosendo2006 grosendo2006 requested a review from santib August 15, 2023 11:31
@santib
Copy link
Member

santib commented Aug 15, 2023

Will te integration with the CI and with knapsack be done as part of this PR?

@santib this is part of adding this gem, and also we're going to merge this and other PRs (integration with the CI and with knapsack) into a release branch, so when we have the functionality working as expected we'll create a new PR to merge against main. That works for you?

Whatever you prefer. What I mean is that we are adding the gem, but the tests aren't running in parallel
image

@grosendo2006
Copy link
Contributor Author

Will te integration with the CI and with knapsack be done as part of this PR?

@santib this is part of adding this gem, and also we're going to merge this and other PRs (integration with the CI and with knapsack) into a release branch, so when we have the functionality working as expected we'll create a new PR to merge against main. That works for you?

Whatever you prefer. What I mean is that we are adding the gem, but the tests aren't running in parallel image

yes, you're right, but to test it locally you have to run this command RAILS_ENV=test rake parallel:spec but this is not the way we're going to run the test, so I just added the gem and after merge this and this other PR we can continue working in order to get both working together

@grosendo2006 grosendo2006 merged commit 9cdd3a7 into release/improve-ci Aug 15, 2023
@grosendo2006 grosendo2006 deleted the add-parell-test branch August 15, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@santib santib santib approved these changes

@enzofab91 enzofab91 enzofab91 approved these changes

@lauperalti lauperalti lauperalti approved these changes

@rodrieiz rodrieiz rodrieiz approved these changes

@megatux megatux Awaiting requested review from megatux

@claudiokerekes claudiokerekes Awaiting requested review from claudiokerekes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@grosendo2006 @santib @megatux @enzofab91 @lauperalti @rodrieiz