iheatmapr no longer produces a working plotly plot

[alanocallaghan]

The yaml file specifying plotly's htmlwidget dependencies is empty in recent versions (plotly/plotly.R@183006c). This code in as_plotly() should fix it (note plotly:::plotlyMainBundle()... it might be worthwhile asking Carson to export that, or some way of producing the plots manually.

I'm submitting a PR but feel free to check it over and/or ask the ropensci team first.

createWidget(name = "plotly",
             x = out,
             width = out$layout$width,
             height = out$layout$height,
             sizingPolicy = sizingPolicy(browser.fill = TRUE,
                                         defaultWidth = "100%",
                                         defaultHeight = 400),
             dependencies = plotly:::plotlyMainBundle(),
             preRenderHook = plotly_build)

[AliciaSchep]

Closed, for more discussion, see #7 and #9. Thanks again for bringing up this issue!

[alanocallaghan]

Makes more sense than relying on plotlys internals, it was simply the path of least resistance for me. Cheers! On 5 Jun 2017 12:08 am, Alicia Schep <notifications@github.com> wrote: Closed, for more discussion, see #7<#7> and #9<#9>. Thanks again for bringing up this issue! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#6 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKR8KEONtnCeUHkAqo-H5WbDTEiLZDnRks5sAzkAgaJpZM4Nq2rk>.