Skip to content

Commit

Permalink
Merge pull request #56 from ropensci/joss
Browse files Browse the repository at this point in the history
  • Loading branch information
jmaspons authored Sep 4, 2024
2 parents 9d92113 + bb22813 commit 2c21a36
Show file tree
Hide file tree
Showing 10 changed files with 192 additions and 25 deletions.
4 changes: 3 additions & 1 deletion .Rbuildignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
^.*\.Rproj$
^CITATION\.cff$
^CODE_OF_CONDUCT\.md$
^CRAN-SUBMISSION$
^LICENSE\.md$
Expand All @@ -12,5 +13,6 @@
^codemeta\.json$
^cran-comments\.md$
^docs$
^paper\.bib$
^paper\.md$
^pkgdown$
^CITATION\.cff$
29 changes: 29 additions & 0 deletions .github/workflows/draft-OpenJournal_paper-pdf.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Draft PDF
on:
push:
paths:
- paper.md
- paper.bib
- .github/workflows/draft-pdf.yml

jobs:
paper:
runs-on: ubuntu-latest
name: Paper Draft
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Build draft PDF
uses: openjournals/openjournals-draft-action@master
with:
journal: joss
# This should be the path to the paper within your repo.
paper-path: paper.md
- name: Upload
uses: actions/upload-artifact@v4
with:
name: paper
# This is the output path where Pandoc will write the compiled
# PDF. Note, this should be the same directory as the input
# paper.md
path: paper.pdf
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: osmapiR
Title: 'OpenStreetMap' API
Version: 0.1.0.9020
Version: 0.2.0
Authors@R: c(
person("Joan", "Maspons", , "joanmaspons@gmail.com", role = c("aut", "cre", "cph"),
comment = c(ORCID = "0000-0003-2286-8727")),
Expand Down
32 changes: 21 additions & 11 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,28 +1,38 @@
# osmapiR (development version)
osmapiR 0.2.0
=============

### New features

* Upgrade logo by @atarom
* Add inst/CITATION
* Improve tests and fix bugs (#35, [08fb4b1](https://github.com/ropensci/osmapiR/commit/08fb4b10abf0270d8bea2473b02b2520ba341521)).
* Add `format = "sf"` for functions returning objects of class `osmapi_map_notes` (#36).
* Add `format = "sf"` for functions returning objects of class `osmapi_changesets` (#37).
* Add `format = "sf"` for `osm_get_gpx_metadata()` (#38).
* Updated links to the new osmapiR home at rOpenSci (#40).
* Add `format = "sf"` for `osm_list_gpxs()` (#42).
* Split functions to parse gpx data from different API endpoints and different properties (#43).
* Add `format = "sf"` for functions returning objects of class `osmapi_gps_track` (#44).
* Add `format = "sf"` for functions returning objects of class `osmapi_gpx` (#45).
* Fix miscalculation of the nchar_url that trigger errors when many ids are requested in osm_fetch_objects().
* Fix changesets' bbox in `st_as_sf.osmapi_chagesets()` ([84f16e7a](https://github.com/ropensci/osmapiR/commit/84f16e7adda087ab707cc2644c79ff1590cf307e)).
* Set encoding to UTF-8 for tags and user names in returned data.frames (#54).
* Parse `<TrackPointExtension>` data from gpx if available (#49).

### Minor improvements

* Upgrade logo by @atarom
* Add inst/CITATION
* Updated links to the new osmapiR home at rOpenSci (#40).
* Split functions to parse gpx data from different API endpoints and different properties (#43).
* Implement NA bboxes in `st_as_sf.osmapi_chagesets()` ([7ea4f5d7](https://github.com/ropensci/osmapiR/commit/7ea4f5d7f412ef8cf7691741b836cf45ddeb61f2)).
* Remove dontrun in examples that don't require authentication (#47).
* Improve performance when parsing gpx data to data.frame (#48).
* Parse TrackPointExtension data from gpx if available (#49).
* Tweaks in DESCRIPTION and CITATION files by @Maelle (#50, #51).
* Sort OSM objects in `osm_get_objects(..., full_objects = TRUE)` and optimize (#52).
* Set encoding to UTF-8 for tags and user names in returned data.frames (#54).

### Bug fixes

* Improve tests and fix bugs (#35, [08fb4b1](https://github.com/ropensci/osmapiR/commit/08fb4b10abf0270d8bea2473b02b2520ba341521)).
* Fix miscalculation of the nchar_url that trigger errors when many ids are requested in `osm_fetch_objects()`.
* Fix changesets' bbox in `st_as_sf.osmapi_chagesets()` ([84f16e7a](https://github.com/ropensci/osmapiR/commit/84f16e7adda087ab707cc2644c79ff1590cf307e)).


# osmapiR 0.1.0
osmapiR 0.1.0
=============

* Initial CRAN submission implementing calls to all the API endpoints.
* Server responses are returned as R objects, xml_documents or json lists.
Expand Down
1 change: 1 addition & 0 deletions README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ knitr::opts_chunk$set(
[![CRAN_Status_Badge](https://www.r-pkg.org/badges/version/osmapiR)](https://cran.r-project.org/package=osmapiR)
[![CRAN Downloads](https://cranlogs.r-pkg.org/badges/grand-total/osmapiR)](https://cran.r-project.org/package=osmapiR)
[![](https://badges.ropensci.org/633_status.svg)](https://github.com/ropensci/software-review/issues/633)
[![status](https://joss.theoj.org/papers/eed311474b650ed64042431a537fbc35/status.svg)](https://joss.theoj.org/papers/eed311474b650ed64042431a537fbc35)
<!-- badges: end -->

An R interface to the [OpenStreetMap API v0.6](https://wiki.openstreetmap.org/wiki/API_v0.6) for fetching and saving raw
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Active](https://www.repostatus.org/badges/latest/active.svg)](https://www.repost
[![CRAN
Downloads](https://cranlogs.r-pkg.org/badges/grand-total/osmapiR)](https://cran.r-project.org/package=osmapiR)
[![](https://badges.ropensci.org/633_status.svg)](https://github.com/ropensci/software-review/issues/633)
[![status](https://joss.theoj.org/papers/eed311474b650ed64042431a537fbc35/status.svg)](https://joss.theoj.org/papers/eed311474b650ed64042431a537fbc35)
<!-- badges: end -->

An R interface to the [OpenStreetMap API
Expand Down
6 changes: 3 additions & 3 deletions codemeta.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"codeRepository": "https://github.com/ropensci/osmapiR",
"issueTracker": "https://github.com/ropensci/osmapiR/issues",
"license": "https://spdx.org/licenses/GPL-3.0",
"version": "0.1.0.9020",
"version": "0.2.0",
"programmingLanguage": {
"@type": "ComputerLanguage",
"name": "R",
Expand Down Expand Up @@ -163,7 +163,7 @@
"SystemRequirements": null
},
"keywords": ["openstreetmap", "OSM", "openstreetmap-api", "osmapi", "API", "osm", "r", "r-package"],
"fileSize": "14091.732KB",
"fileSize": "14092.409KB",
"citation": [
{
"@type": "SoftwareSourceCode",
Expand All @@ -180,7 +180,7 @@
"name": "osmapiR: OpenStreetMap API",
"identifier": "10.32614/CRAN.package.osmapiR",
"url": "https://docs.ropensci.org/osmapiR/",
"description": "R package version 0.1.0.9020 \nhttps://github.com/ropensci/osmapiR",
"description": "R package version 0.2.0 \nhttps://github.com/ropensci/osmapiR",
"@id": "https://doi.org/10.32614/CRAN.package.osmapiR",
"sameAs": "https://doi.org/10.32614/CRAN.package.osmapiR"
}
Expand Down
9 changes: 0 additions & 9 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,4 @@

0 errors | 0 warnings | 0 note

* This is a new release.

urlchecker::url_check() errors and warnings for links that require authentication

## Resubmission

Addressed comments by Benjamin Altmann:

* DESCRIPTION: package names, software names and API names in single quotes in title and description
* Remove commented code lines in examples
82 changes: 82 additions & 0 deletions paper.bib
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
@Manual{R,
title = {R: A Language and Environment for Statistical Computing},
author = {{R Core Team}},
organization = {R Foundation for Statistical Computing},
address = {Vienna, Austria},
year = {2024},
url = {https://www.R-project.org/},
}

@Manual{osmapiR,
title = {osmapiR: OpenStreetMap API},
author = {Joan Maspons},
note = {R package version 0.2.0 https://github.com/ropensci/osmapiR},
year = {2024},
url = {https://docs.ropensci.org/osmapiR/},
doi = {10.32614/CRAN.package.osmapiR},
}

@Article{osmdata,
title = {osmdata},
author = {Mark Padgham and Bob Rudis and Robin Lovelace and Maëlle Salmon},
journal = {Journal of Open Source Software},
year = {2017},
volume = {2},
number = {14},
pages = {305},
month = {jun},
publisher = {The Open Journal},
url = {https://joss.theoj.org/papers/10.21105/joss.00305},
doi = {10.21105/joss.00305},
}

@Manual{osmextract,
title = {osmextract: Download and Import Open Street Map Data Extracts},
author = {Andrea Gilardi and Robin Lovelace},
year = {2024},
note = {R package version 0.5.1},
url = {https://CRAN.R-project.org/package=osmextract},
doi = {10.32614/CRAN.package.osmextract},
}

@Manual{OpenStreetMap_package,
title = {OpenStreetMap: Access to Open Street Map Raster Images},
author = {Ian Fellows and Jan Peter Stotz},
year = {2023},
note = {R package version 0.4.0},
url = {https://CRAN.R-project.org/package=OpenStreetMap},
doi = {10.32614/CRAN.package.OpenStreetMap},
}

@Article{sf,
author = {Edzer Pebesma},
title = {{Simple Features for R: Standardized Support for Spatial Vector Data}},
year = {2018},
journal = {{The R Journal}},
doi = {10.32614/RJ-2018-009},
url = {https://doi.org/10.32614/RJ-2018-009},
pages = {439--446},
volume = {10},
number = {1},
}

@Manual{xml2,
title = {xml2: Parse XML},
author = {Hadley Wickham and Jim Hester and Jeroen Ooms},
year = {2023},
note = {R package version 1.3.6},
url = {https://CRAN.R-project.org/package=xml2},
doi = {10.32614/CRAN.package.xml2},
}

@article{kolb2019,
author = {Jan-Philipp Kolb},
title = {{Using Web Services to Work with Geodata in R}},
year = {2019},
journal = {{The R Journal}},
doi = {10.32614/RJ-2019-041},
url = {https://doi.org/10.32614/RJ-2019-041},
pages = {6--23},
volume = {11},
number = {2}
}
51 changes: 51 additions & 0 deletions paper.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
---
title: "osmapiR: An 'OpenStreetMap API' implementation for R"
tags:
- openstreetmap
- OSM
- spatial
- R
authors:
- name: Joan Maspons
orcid: 0000-0003-2286-8727
affiliation: 1
# corresponding: true
affiliations:
- name: Independent researcher, Catalonia
index: 1
date: 22 July 2024
bibliography: paper.bib
# nocite: |
# @*
---

# Summary

`osmapiR` [@osmapiR] is a complete implementation of the
[OpenStreetMap API](https://wiki.openstreetmap.org/wiki/API_v0.6) for `R` [@R].
OpenStreetMap (OSM) is a global, crowdsourced geographic database licensed under the [Open Database License](https://www.openstreetmap.org/copyright).
The OSM project follows a peer production model similar to Wikipedia.


# Statement of need

The `osmapiR` package facilitates to retrieve all types of OSM data, including map data, map notes, GPS traces,
changelogs, and user data.
The data can be imported into R as `data.frame`, `sf` [@sf], `xml_document` [@xml2], or JSON lists.
Editing the OSM database is also supported with specific functions to send changes directly to the OSM database or to
generate and export changes in [Osmchange format](https://wiki.openstreetmap.org/wiki/OsmChange), compatible with other
editors such as JOSM.

`osmapiR` is the only R package that allows access to non-map OSM data (map notes, GPS traces, changelogs and users
data), as well as the ability to edit and upload any kind of data to the project.
It is also useful for obtaining the history of the OSM map objects.
The OpenStreetMap API is not intended to access objects from OSM map data for read-only purposes, as required by the
[API Usage Policy](https://operations.osmfoundation.org/policies/api/).
For such purposes, the use of `osmdata` or `osmextract` packages is recommended.
`osmdata` uses the Overpass API [@osmdata] and works well for moderated size datasets or to access objects filtered by
tags.
`osmextract` works with local `pbf` files [@osmextract] and is the recommended tool to work with big datasets.
For a review of options to access online geodata in R, including OSM data, see @kolb2019.


# References

0 comments on commit 2c21a36

Please sign in to comment.