-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission: rio #605
Comments
Thanks for submitting to rOpenSci, our editors and @ropensci-review-bot will reply soon. Type |
🚀 Editor check started 👋 |
Checks for rio (v0.5.30)git hash: daf6cd15
Important: All failing checks above must be addressed prior to proceeding (Checks marked with 👀 may be optionally addressed.) Package License: GPL-2 1. Package DependenciesDetails of Package Dependency Usage (click to open)
The table below tallies all function calls to all packages ('ncalls'), both internal (r-base + recommended, along with the package itself), and external (imported and suggested packages). 'NA' values indicate packages to which no identified calls to R functions could be found. Note that these results are generated by an automated code-tagging system which may not be entirely accurate.
Click below for tallies of functions used in each package. Locations of each call within this package may be generated locally by running 's <- pkgstats::pkgstats(<path/to/repo>)', and examining the 'external_calls' table. basefile (148), which (46), list (30), c (29), lapply (16), names (14), for (11), attributes (10), do.call (9), paste0 (9), seq_along (9), args (7), row.names (7), invisible (6), length (6), unlist (6), drop (5), sapply (5), try (5), url (5), as.character (4), format (4), nchar (4), tempfile (4), basename (3), col (3), new.env (3), raw (3), regexpr (3), regmatches (3), rep (3), return (3), seq_len (3), strsplit (3), unclass (3), class (2), cumsum (2), formals (2), gettext (2), grep (2), gsub (2), levels (2), max (2), nrow (2), readLines (2), setdiff (2), sort (2), switch (2), table (2), tolower (2), unique (2), alist (1), as.environment (1), as.numeric (1), attr (1), by (1), cbind.data.frame (1), comment (1), dump (1), duplicated (1), getOption (1), getwd (1), if (1), is.na (1), labels (1), library (1), match.arg (1), match.call (1), ncol (1), paste (1), quote (1), read.dcf (1), readBin (1), rownames (1), sink (1), sprintf (1), structure (1), sub (1), substitute (1), system.file (1), T (1) rioimport (4), twrap (3), arg_reconcile (2), doone (2), export (2), extract_html_row (2), find_compress (2), get_ext (2), uninstalled_formats (2), characterize (1), characterize.data.frame (1), characterize.default (1), compress_out (1), convert (1), convert_google_url (1), export_delim (1), factorize (1), factorize.data.frame (1), factorize.default (1), gather_attrs (1), standardize_attributes (1) utilsdata (5), unzip (5), untar (4), type.convert (2), zip (2), head (1), packageName (1), read.fortran (1), tar (1), write.table (1) xml2read_xml (4), xml_add_child (4), read_html (3), as_list (2), xml_find_all (2), xml_attrs (1), xml_children (1) havenwrite_sav (4), write_dta (2), write_sas (2), write_xpt (2), read_sas (1) toolsfile_ext (5), file_path_sans_ext (3) openxlsxaddWorksheet (1), getSheetNames (1), loadWorkbook (1), saveWorkbook (1), write.xlsx (1) grDevicesbmp (1), jpeg (1), png (1), tiff (1) cliprread_clip (1), read_clip_tbl (1), write_clip (1) data.tablerbindlist (2), fwrite (1) foreignread.dta (1), read.systat (1), write.dbf (1) graphicstitle (2), text (1) pzfxread_pzfx (2), write_pzfx (1) rmatiowrite.mat (2), read.mat (1) statssetNames (3) curlcurl_fetch_memory (1), parse_headers (1) featherread_feather (1), write_feather (1) fstread.fst (1), write.fst (1) readODSread_ods (1), write_ods (1) readrfwf_empty (1), read_fwf (1) arrowwrite_parquet (1) jsonlitefromJSON (1) methodsis (1) readxlexcel_sheets (1) tibbleas_tibble (1) 2. Statistical PropertiesThis package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing. Details of statistical properties (click to open)
The package has:
Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages
All parameters are explained as tooltips in the locally-rendered HTML version of this report generated by the The final measure (
2a. Network visualisationClick to see the interactive network visualisation of calls between objects in package 3.
|
id | name | conclusion | sha | run_number | date |
---|---|---|---|---|---|
6010120891 | pages build and deployment | failure | 57d3a2 | 5 | 2023-08-29 |
6012061439 | R-CMD-check | success | fd7053 | 6 | 2023-08-29 |
6012061436 | test-coverage | success | fd7053 | 18 | 2023-08-29 |
3b. goodpractice
results
R CMD check
with rcmdcheck
rcmdcheck found no errors, warnings, or notes
Test coverage with covr
Package coverage: 87.35
Cyclocomplexity with cyclocomp
The following functions have cyclocomplexity >= 15:
function | cyclocomplexity |
---|---|
import_list | 31 |
import | 24 |
arg_reconcile | 20 |
import_delim | 18 |
set_class | 17 |
Static code analyses with lintr
lintr found the following 314 potential issues:
message | number of times |
---|---|
Avoid 1:nrow(...) expressions, use seq_len. | 2 |
Avoid changing the working directory, or restore it in on.exit | 3 |
Avoid library() and require() calls in packages | 4 |
Avoid using sapply, consider vapply instead, that's type safe | 8 |
Lines should not be more than 80 characters. | 297 |
4. Other Checks
Details of other checks (click to open)
✖️ The following 4 function names are duplicated in other packages:
-
convert
from AquaEnv, ascii, breakaway, cabootcrs, CHNOSZ, convertr, coreCT, DDIwR, equateIRT, hablar, khroma, nCov2019, phenopix, qtl, quanteda, rMIDAS, scan, StratigrapheR, tidygraph, tis, wavethresh
-
export
from admisc, aLFQ, box, box, bruceR, campsismod, crestr, EviewsR, flux, fsbrain, gm, grainscape, inTextSummaryTable, job, kimisc, Momocs, Morpho, mpm, pitchRx, scan, seewave, soc.ca, strvalidator, tipsae, wpa
-
factorize
from admisc, conf.design, elliptic, Epi, gmp, labdsv, lme4, mosaic, QCApro, RcmdrPlugin.KMggplot2, rminer, sfsmisc
-
import
from act, aLFQ, ambiorix, backports, bruceR, EviewsR, fSRM, importar, isqg, MALDIquantForeign, NMproject, openair, reticulate, reticulate, rTorch, strvalidator, tensorflow
Package Versions
package | version |
---|---|
pkgstats | 0.1.3.7 |
pkgcheck | 0.1.2.1 |
Editor-in-Chief Instructions:
Processing may not proceed until the items marked with ✖️ have been resolved.
Pending: write a Vignette instead
@ropensci-review-bot help |
Hello @chainsawriot, here are the things you can ask me to do:
|
@ropensci-review-bot check package |
Thanks, about to send the query. |
🚀 Editor check started 👋 |
@ropensci My local check with |
httr::HEAD("https://badges.ropensci.org/605_status.svg")
#> Response [https://badges.ropensci.org/605_status.svg]
#> Date: 2023-08-30 15:32
#> Status: 404
#> Content-Type: text/html; charset=utf-8
#> <EMPTY BODY> Created on 2023-08-30 with reprex v2.0.2 |
Thank you for this submission @chainsawriot! I realize the last response from the bot is an error, as a badge should not be generated or checked for until after an editor has approved moving forward with the process. I believe rio is out of scope for us. Per the package descriptions in our Aims and Scope, retrieval, extraction, or munging categories should be specific to "data sources / topics", "aid in retrieving data from unstructured sources such as text, images and PDFs, as well as parsing scientific data types and outputs from scientific equipment", or "focus on tools for handling data in specific scientific formats generated from scientific workflows or exported from scientific instruments." The reason for this is that it is hard to have objective reviews for where we draw on relevant field expertise with highly general/swiss army tools. The latter are more likely to have a lot of users that provide feedback so need the review process less. I would recommend JOSS as a venue for reviewing and publishing rio. |
David Schoch (4): removed importFrom [no ci] (#325) (#338) export several files to zip file fix #203 [no ci] (#346) removed else clutter fix #334 (#360) Deprecate unused arguments fix #343 #253 (#362) chainsawriot (66): Update `.Rbuildignore` [no ci] Update README [no ci] Add code meta ref ropensci/software-review#605 Remove the doc of `arg_reconcile` [no ci] ref #320 ropensci/software-review#605 Style Add examples to `get_ext` [no ci] ref ropensci/software-review#605 Add examples to `install_formats()` [no ci] ref ropensci/software-review#605 Document the return value of `characterize` [no ci] ref ropensci/software-review#605 Unexport .export .import ref #320 ropensci/software-review#605 Update codemeta.json [no ci] Fix the arrow test error for arrow 7 Disable the shorten URL test Fix #301 Remove the obsolete data.table option change (#323) Add `.check_pkg_availability` fix #296 (#324) Unexport `is_file_text` [no ci] Update NEWS.md [no ci] Update caution about HTML tables, fix #265 [no ci] Solve gp issue on 1: ref #319 Rewrite all docs in Markdown fix #311 (#328) Fix #327 [no ci] (#329) Make ... pass Ref #318 (#330) Fix #318 (#331) Zap all sapply fix #319 (#332) Change the ownership to gesistsa Remove code meta [no ci] Zap the last sapply [no ci] Fix #301 [no ci] (#333) Fix #294 (#337) Add schochastics as ctb [no ci] Update NEWS.md [no ci] Fix #303 [no ci] (#339) Update NEWS and CITATION [no ci] Make `Package Philosphy` a vignette [no ci] ref #320 (#342) Fix #340 [no ci] (#344) Fix #347 [no ci] (#348) Update NEWS [no ci] Update NEWS.md [no ci] Implement a single source of truth [no ci] ref #313 (#349) Use `format` in internal data [no ci] (#352) Remove `ext` in internal data ref #313 [no ci] (#353) Fix #350 fix #351 (#355) Make `install_formats()` use internal data too ref #313 Use stats::na.omit Add a guide on how to update the internal data Update NEWS.md [no ci] Remove commented code in suggestions.R Zap `openxlsx` and use `writexl` instead, fix #310 (#359) Add the universal dummy which parameter to all import methods #326 [no ci] (#361) Update NEWS.md [no ci] Fix #326 (#364) Add extension Vignette (#365) Fix #315 (#367) Update doc fix #315 again [no ci] (#369) Update Internal data [no ci] Again [no ci] Add labelled vig (#370) Fix Labelled vig. [no ci] (#371) Fix #368 (#372) Fix #363 [no ci] (#373) Wrap all calls with `.docall` [no ci] (#374) Fix #358 [no ci] (#375) New logo [no ci] Bump ver. CRAN ready [no ci] Remove `gather_attrs` example [no ci] Fix #376 (#377) schochastics (8): added import method for qs added full support for qs added tests added qs to list [no ci] added qs [no ci] make setclass authoritative #336 added how to set default setclass in example deleted commented out test [no ci]
Submitting Author Name: Chung-hong Chan
Submitting Author Github Handle: @chainsawriot
Other Package Authors Github handles: (comma separated, delete if none) @leeper
Repository: https://github.com/chainsawriot/rio
Version submitted: 0.5.30
Submission type: Standard
Editor: TBD
Reviewers: TBD
Archive: TBD
Version accepted: TBD
Language: en
Scope
Please indicate which category or categories from our package fit policies this package falls under: (Please check an appropriate box below. If you are unsure, we suggest you make a pre-submission inquiry.):
Explain how and why the package falls under these categories (briefly, 1-2 sentences):
This package is for loading and saving data from either files or urls.
Probably all scientific disciplines that involve dealing with data files.
As far as I know there are four: reader (not readr), io, ImportExport, and SchemaOnRead. The current package is probably the most used.
Yes
No. I am sorry.
pkgcheck
items which your package is unable to pass.Technical checks
Confirm each of the following by checking the box.
This package:
Publication options
Do you intend for this package to go on CRAN?
Do you intend for this package to go on Bioconductor?
Do you wish to submit an Applications Article about your package to Methods in Ecology and Evolution? If so:
MEE Options
Code of conduct
The text was updated successfully, but these errors were encountered: