Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginnings of 0.2.2 release prep #236

Merged
merged 6 commits into from
Dec 1, 2017

Conversation

Robinlovelace
Copy link
Member

No description provided.

@mpadge
Copy link
Member

mpadge commented Nov 29, 2017

''sf, the future of geographic vector data in R'' - bold statement, mate!

@Robinlovelace
Copy link
Member Author

Good review - will tone it down. Thanks.

@richardellison
Copy link
Collaborator

Yes, agreed although it certainly has some traction.

Happy to merge unless you're planning on putting more commits in for this?

@Robinlovelace
Copy link
Member Author

I'm happy for this to be merged in its toned-down state. I'm not planning to submit this to CRAN just yet but certainly before Christmas. How does this seems as an approach to making plotting work?

#' sp/sf plots
#'
#' @name plot
#' @export
#' @importFrom sp plot
NULL

@Robinlovelace
Copy link
Member Author

To go into stplanr-package.R

@Robinlovelace
Copy link
Member Author

Actually scrap that plan: it seems that plotting still works even though sp:::plot is not exported. Must be because it's a generic method... Illustrated in reprex below.

@Robinlovelace
Copy link
Member Author

devtools::install_github("ropensci/stplanr")
sessionInfo()
library(stplanr)
sessionInfo()
l_sf = od2line(flow, cents_sf)
plot(l$geometry)
l_sp = od2line(flow, cents)
plot(l_sp)

@Robinlovelace
Copy link
Member Author

devtools::install_github("ropensci/stplanr")
#> Skipping install of 'stplanr' from a github remote, the SHA1 (c4845c92) has not changed since last install.
#>   Use `force = TRUE` to force installation
sessionInfo()
#> R version 3.4.2 (2017-09-28)
#> Platform: x86_64-pc-linux-gnu (64-bit)
#> Running under: Ubuntu 16.04.3 LTS
#> 
#> Matrix products: default
#> BLAS: /usr/lib/openblas-base/libblas.so.3
#> LAPACK: /usr/lib/libopenblasp-r0.2.18.so
#> 
#> locale:
#>  [1] LC_CTYPE=en_GB.UTF-8       LC_NUMERIC=C              
#>  [3] LC_TIME=en_GB.UTF-8        LC_COLLATE=en_GB.UTF-8    
#>  [5] LC_MONETARY=en_GB.UTF-8    LC_MESSAGES=en_GB.UTF-8   
#>  [7] LC_PAPER=en_GB.UTF-8       LC_NAME=C                 
#>  [9] LC_ADDRESS=C               LC_TELEPHONE=C            
#> [11] LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C       
#> 
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base     
#> 
#> loaded via a namespace (and not attached):
#>  [1] Rcpp_0.12.14     digest_0.6.12    withr_2.1.0.9000 rprojroot_1.2   
#>  [5] R6_2.2.2         backports_1.1.1  git2r_0.19.0     formatR_1.5     
#>  [9] magrittr_1.5     evaluate_0.10.1  httr_1.3.1       stringi_1.1.6   
#> [13] curl_3.0         rmarkdown_1.8    devtools_1.13.4  tools_3.4.2     
#> [17] stringr_1.2.0    yaml_2.1.14      compiler_3.4.2   memoise_1.1.0   
#> [21] htmltools_0.3.6  knitr_1.17
library(stplanr)
sessionInfo()
#> R version 3.4.2 (2017-09-28)
#> Platform: x86_64-pc-linux-gnu (64-bit)
#> Running under: Ubuntu 16.04.3 LTS
#> 
#> Matrix products: default
#> BLAS: /usr/lib/openblas-base/libblas.so.3
#> LAPACK: /usr/lib/libopenblasp-r0.2.18.so
#> 
#> locale:
#>  [1] LC_CTYPE=en_GB.UTF-8       LC_NUMERIC=C              
#>  [3] LC_TIME=en_GB.UTF-8        LC_COLLATE=en_GB.UTF-8    
#>  [5] LC_MONETARY=en_GB.UTF-8    LC_MESSAGES=en_GB.UTF-8   
#>  [7] LC_PAPER=en_GB.UTF-8       LC_NAME=C                 
#>  [9] LC_ADDRESS=C               LC_TELEPHONE=C            
#> [11] LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C       
#> 
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base     
#> 
#> other attached packages:
#> [1] stplanr_0.2.1
#> 
#> loaded via a namespace (and not attached):
#>  [1] Rcpp_0.12.14      compiler_3.4.2    formatR_1.5      
#>  [4] git2r_0.19.0      bindr_0.1         class_7.3-14     
#>  [7] R.methodsS3_1.7.1 R.utils_2.6.0     tools_3.4.2      
#> [10] digest_0.6.12     evaluate_0.10.1   memoise_1.1.0    
#> [13] tibble_1.3.4      lattice_0.20-35   pkgconfig_2.0.1  
#> [16] rlang_0.1.4       openxlsx_4.0.17   igraph_1.1.2     
#> [19] DBI_0.7           curl_3.0          yaml_2.1.14      
#> [22] rgdal_1.2-16      bindrcpp_0.2      e1071_1.6-8      
#> [25] raster_2.6-7      withr_2.1.0.9000  httr_1.3.1       
#> [28] stringr_1.2.0     dplyr_0.7.4       knitr_1.17       
#> [31] rgeos_0.3-26      devtools_1.13.4   classInt_0.1-24  
#> [34] rprojroot_1.2     grid_3.4.2        glue_1.2.0       
#> [37] sf_0.5-6          R6_2.2.2          foreign_0.8-69   
#> [40] rmarkdown_1.8     sp_1.2-5          udunits2_0.13    
#> [43] magrittr_1.5      units_0.4-6       backports_1.1.1  
#> [46] htmltools_0.3.6   maptools_0.9-2    assertthat_0.2.0 
#> [49] geosphere_1.5-7   stringi_1.1.6     R.oo_1.21.0
l_sf = od2line(flow, cents_sf)
plot(l_sf$geometry)

l_sp = od2line(flow, cents)
plot(l_sp)

@richardellison richardellison merged commit 96d1052 into ropensci:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants