Allow s-maxage to be parsed #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-age and s-maxage serve the same purpose and work the same way. The order of priority is as follow: * First priority on s-maxage * Then on max-age * Then on expires Here is the RFC regarding the s-maxage: https://tools.ietf.org/html/rfc7234#section-5.2.2.9
|
@roryf what do you think? please advise. |
roryf
requested changes
Sep 15, 2016
| .filter(function (key) { return header[key]; }) | ||
| .forEach(function (key) { | ||
| try { | ||
| var maxAge = parseInt(header[key], 10); |
There was a problem hiding this comment.
Minor, but could this be renamed to something like headerValue? Given that this is now concerned with any value that should be numeric.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max-age and s-maxage serve the same purpose and work the same way. The order of priority is as follow:
Here is the RFC regarding the s-maxage:
https://tools.ietf.org/html/rfc7234#section-5.2.2.9