New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remodel component interfaces #203
Conversation
114e8b4
to
f566057
Compare
32bf738
to
127008d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Happy to merge once we settled the std::move point.
5a27bf8
to
4570e39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few discussion points.
Most importantly: I am not sure we need templates with Handles/Interfaces. Or we could use templates to set the data type of Handle/Interface (in general it has not be double, it could be also bool for valves or some status string)
hardware_interface/include/hardware_interface/components/system_interface.hpp
Show resolved
Hide resolved
hardware_interface/include/hardware_interface/hardware_info.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
9f82e64
to
608ad83
Compare
I've rebased this PR after merging #209 |
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 31.41% 32.73% +1.31%
==========================================
Files 38 44 +6
Lines 2489 2688 +199
Branches 1638 1734 +96
==========================================
+ Hits 782 880 +98
- Misses 251 258 +7
- Partials 1456 1550 +94
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Second part of #164
Introduces
StateHandle
andCommandHandle
.Adapts the hardware components interfaces to instantiate these handles given the configuration info passed to the components on a prior call to
configure
.Sits on top of #201