Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning Controller Interface from obsolete code. #655

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Cleaning Controller Interface from obsolete code. #655

merged 2 commits into from
Feb 28, 2022

Conversation

destogl
Copy link
Member

@destogl destogl commented Feb 24, 2022

  • Remove obsolete pre-compiler commands for OSx
  • Remove deprecated return type from controller_interface.

@destogl destogl self-assigned this Feb 24, 2022
@bmagyar bmagyar changed the title Cleaning Controller Interface from obssolete code. Cleaning Controller Interface from obsolete code. Feb 25, 2022
@bmagyar bmagyar merged commit 8b23233 into master Feb 28, 2022
@destogl destogl deleted the controller-interface-small-fixes branch March 1, 2022 08:37
pac48 pushed a commit to pac48/ros2_control that referenced this pull request Jan 26, 2024
@mergify @bmagyar
Second round of dependencies fix (ros-controls#655) (ros-controls#656)
8bfee4b 
* Add missing backward_ros dependency and minor cmake cleanup
* Fix unused arg warning

(cherry picked from commit d96f662b9830e030ea80e6564952730744c9c594)

Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malapatiravi malapatiravi malapatiravi approved these changes

@bmagyar bmagyar bmagyar approved these changes

@a10263790 a10263790 Awaiting requested review from a10263790

@kasiceo kasiceo Awaiting requested review from kasiceo

@livanov93 livanov93 Awaiting requested review from livanov93

@VX792 VX792 Awaiting requested review from VX792

Assignees

@destogl destogl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@destogl @bmagyar @malapatiravi