Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make interface_list_contains_interface_type inline #721

Merged
merged 1 commit into from
May 23, 2022
Merged

Make interface_list_contains_interface_type inline #721

merged 1 commit into from
May 23, 2022

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented May 19, 2022

Fixes #720

@bmagyar
Copy link
Member Author

bmagyar commented May 19, 2022

After careful design, consideration and weeks of coding, I'm done with the implementation.
What do you think, @Mikumiku747 ?

@Mikumiku747
Copy link

After careful design, consideration and weeks of coding, I'm done with the implementation. What do you think, @Mikumiku747 ?

Thanks @bmagyar , I can see a lot of blood, sweat and tears went into it. In all seriousness, I've only ever used git for small projects at Uni so I've never done pull requests before, I'll give it a go myself next time, thanks for the change. Shame it's probably too late to make it into ros-humble.

@bmagyar
Copy link
Member Author

bmagyar commented May 20, 2022

It's a change that will make it into humble and I can also backport to foxy and galactic. It doesn't change API.nor ABI while it fixes an actual issue

@bmagyar
Copy link
Member Author

bmagyar commented May 23, 2022

@Mergifyio backport to galactic

@bmagyar
Copy link
Member Author

bmagyar commented May 23, 2022

@Mergifyio backport to foxy

@mergify
Copy link
Contributor

mergify bot commented May 23, 2022

backport to galactic

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented May 23, 2022

backport to foxy

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@bmagyar bmagyar merged commit 214c2c4 into master May 23, 2022
mergify bot pushed a commit that referenced this pull request May 23, 2022
@bmagyar @mergify
Make interface_list_contains_interface_type inline (#721)
1031b5d 
(cherry picked from commit 214c2c4)
@mergify mergify bot mentioned this pull request May 23, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented May 23, 2022

backport to foxy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 23, 2022
@bmagyar @mergify
Make interface_list_contains_interface_type inline (#721)
aa3882f 
(cherry picked from commit 214c2c4)
@mergify mergify bot mentioned this pull request May 23, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented May 23, 2022

backport to galactic

✅ Backports have been created

bmagyar added a commit that referenced this pull request May 23, 2022
@mergify @bmagyar
Make interface_list_contains_interface_type inline (#721) (#723)
1e6ac9f 
(cherry picked from commit 214c2c4)

Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
bmagyar added a commit that referenced this pull request May 23, 2022
@mergify @bmagyar
Make interface_list_contains_interface_type inline (#721) (#722)
ea4428b 
(cherry picked from commit 214c2c4)

Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
@bmagyar bmagyar deleted the bmagyar-patch-2 branch July 12, 2022 07:36
pac48 pushed a commit to pac48/ros2_control that referenced this pull request Jan 26, 2024
@mergify
Fix out of bound access in admittance controller (ros-controls#721) (r…
4f0b6c0 
…os-controls#722)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprotyas aprotyas aprotyas approved these changes

@Briancbn Briancbn Awaiting requested review from Briancbn

@destogl destogl Awaiting requested review from destogl

@harderthan harderthan Awaiting requested review from harderthan

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@Serafadam Serafadam Awaiting requested review from Serafadam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change interface_list_contains_interface_type to inline
3 participants
@bmagyar @Mikumiku747 @aprotyas