-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added time param in update_reference_from_subscribers() #846
added time param in update_reference_from_subscribers() #846
Conversation
In my opinion, the .vscode configuration files should not be included in the merge request |
@anfemosa Thankyou for the feedback. It makes sense. I will remove them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
4981d6d
to
8f96281
Compare
e49a5d5
to
c95579d
Compare
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
==========================================
- Coverage 34.61% 32.77% -1.85%
==========================================
Files 52 91 +39
Lines 2981 9467 +6486
Branches 1855 6367 +4512
==========================================
+ Hits 1032 3103 +2071
- Misses 310 689 +379
- Partials 1639 5675 +4036
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Looks good 👏🏽 |
controller_manager/test/test_chainable_controller/test_chainable_controller.hpp
Outdated
Show resolved
Hide resolved
…le_controller.hpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…nce_from_subscribers() (ros-controls#846) #API-break * Add Migration file for API breaking changes. Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
…nce_from_subscribers() (ros-controls#846) #API-break * Add Migration file for API breaking changes. Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
…nce_from_subscribers() (ros-controls#846) #API-break * Add Migration file for API breaking changes. Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
…nce_from_subscribers() (ros-controls#846) #API-break * Add Migration file for API breaking changes. Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
…nce_from_subscribers() (ros-controls#846) #API-break * Add Migration file for API breaking changes. Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
to calculate ageOfLastCommand and use reference_timeout variable in chainable and standard controller setup a time param is required inupdate_reference_from_subscribers(
const rclcpp::Time & time, const rclcpp::Duration & /period/) as in update_and_write_commands(
const rclcpp::Time & time, const rclcpp::Duration & /period/)