Closes #796 - Adds list_hardware_components to CLI #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcevoyandy
commented
Jan 10, 2023
mcevoyandy
commented
Jan 10, 2023
github-actions
bot
requested review from
aprotyas,
bmagyar,
destogl,
duringhof,
livanov93 and
mcbed
bmagyar
reviewed
Jan 21, 2023
bmagyar
reviewed
Jan 21, 2023
| # limitations under the License. | ||
|
|
||
| from controller_manager import list_hardware_components | ||
| from controller_manager.spawner import bcolors |
There was a problem hiding this comment.
It may be a better idea to move those colours to a separate file and avoid importing things from spawner by accident. It could be a new issue
There was a problem hiding this comment.
It looks like bcolors is only used in spawner.py and list_hardware_interfaces.py. I can separate that in a new PR.
bmagyar
reviewed
Jan 21, 2023
bmagyar
reviewed
Jan 21, 2023
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
mcevoyandy
force-pushed
the
796-add-list-hardware-components-cli
branch
from
8157eb6
to
912239c
Compare
destogl
reviewed
Jan 25, 2023
bmagyar
previously approved these changes
Jan 28, 2023
bmagyar
approved these changes
Jan 31, 2023
|
@Mergifyio backport humble |
✅ Backports have been created
|
mamueluth
pushed a commit
to StoglRobotics-forks/ros2_control
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CLI for
list_hardware_components. Closes #796.