Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong CLI output of controller states #947

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix wrong CLI output of controller states #947

merged 1 commit into from
Feb 21, 2023

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Feb 20, 2023 •
edited
Loading

@christophfroehlich
Copy link
Contributor Author

christophfroehlich commented Feb 20, 2023 •
edited
Loading

I realized now that the drepecations are still in SwitchController.srv and controller_manager itself. Should I remove them in a separate PR or include it all in this one?

@christophfroehlich christophfroehlich marked this pull request as draft February 20, 2023 19:27
@bmagyar
Copy link
Member

bmagyar commented Feb 20, 2023

I'd prefer to handle deprecation work on a separate PR

@christophfroehlich christophfroehlich marked this pull request as ready for review February 20, 2023 21:13
@christophfroehlich
Copy link
Contributor Author

removed deprecation stuff -> ready for review

bmagyar
bmagyar approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@destogl destogl merged commit a676d3c into ros-controls:master Feb 21, 2023
@destogl
Copy link
Member

destogl commented Feb 21, 2023

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Feb 21, 2023 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 21, 2023
@christophfroehlich @mergify
[CLI] Fix wrong output of controller states for load_controller com…
597855b 
…mand (#947)

(cherry picked from commit a676d3c)

# Conflicts:
#	ros2controlcli/ros2controlcli/verb/load_controller.py
#	ros2controlcli/ros2controlcli/verb/set_controller_state.py
@destogl
Copy link
Member

destogl commented Feb 21, 2023

@christophfroehlich can you also adjust back ported branch so that it doesn't have breaking changes. Or this doesn't make sense.

@mergify mergify bot mentioned this pull request Feb 21, 2023
Merged
@christophfroehlich christophfroehlich deleted the fix_cli_output branch February 21, 2023 17:42
bmagyar pushed a commit that referenced this pull request Feb 22, 2023
@mergify @christophfroehlich @destogl
Fix wrong CLI output of controller states (backport #947) (#951)
da5f448 
* [CLI] Fix wrong output of controller states for `load_controller` command (#947)

(cherry picked from commit a676d3c)

# Conflicts:
#	ros2controlcli/ros2controlcli/verb/load_controller.py
#	ros2controlcli/ros2controlcli/verb/set_controller_state.py

* Make changes non-breaking

---------

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
pac48 pushed a commit to pac48/ros2_control that referenced this pull request Jan 26, 2024
@mergify
Do not run reviewer lottery for dependabot and mergify (ros-controls#946
2a0c387 
) (ros-controls#947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@destogl destogl destogl approved these changes

@arne48 arne48 Awaiting requested review from arne48

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@jaron-l jaron-l Awaiting requested review from jaron-l

@mcbed mcbed Awaiting requested review from mcbed

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@homalozoa homalozoa Awaiting requested review from homalozoa

@jackcenter jackcenter Awaiting requested review from jackcenter

@malapatiravi malapatiravi Awaiting requested review from malapatiravi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing feedback when loading controller from CLI
3 participants
@christophfroehlich @bmagyar @destogl