Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 Control Components - PositionJoint #140

Closed

Conversation

destogl
Copy link
Member

@destogl destogl commented Sep 10, 2020

This PR creates ros2_control_components package and the implementation of PositionJoint component.

It also influenced hardware_interface package by:

  • component_lists_management.hpp file is moved to include folder to be accessible from other packages
  • extending component_lists_management.hpp with limit handling functions
  • add additional return types for limit errors
  • make methods in Joint and Sensor classes virtual

@destogl destogl marked this pull request as draft September 10, 2020 12:08
@destogl destogl changed the title WIP: ROS2 Control Components - PositionJoint ROS2 Control Components - PositionJoint Sep 10, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   37.25%   37.25%           
=======================================
  Files          44       44           
  Lines        1863     1863           
  Branches     1136     1136           
=======================================
  Hits          694      694           
  Misses        130      130           
  Partials     1039     1039           
Flag Coverage Δ
#unittests 37.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nterface/components/component_lists_management.hpp 81.25% <ø> (ø)
hardware_interface/src/components/joint.cpp 100.00% <ø> (ø)
hardware_interface/src/components/sensor.cpp 86.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3aad1...6c44d6a. Read the comment docs.

@destogl
Copy link
Member Author

destogl commented Oct 1, 2020

So initial implementation is finished. Very simple and functional.

@destogl
Copy link
Member Author

destogl commented Oct 1, 2020

@bmagyar something strange happened with the docker server. is it possible to restart the jobs manually? I am not able to do that...

@destogl
Copy link
Member Author

destogl commented Oct 29, 2020

This will be considered in #219 is abstraction of Joint is needed/wanted.

Closing as discussed in the meeting on 21st of October 2020.

@destogl destogl closed this Oct 29, 2020
@destogl destogl deleted the add_ros2_control_components branch October 29, 2020 13:36
destogl added a commit to StoglRobotics-forks/ros2_control that referenced this pull request Aug 11, 2022
…n interfaces (ros-controls#140)

* Test position only version of JTC for KUKA RSI robots.
* All changes in JTC added
* Don't freak out when wait set can't be established
* Test should expect that before a run, controller is unconfigured as well as after an unsuccessful configure call
* joint_trajectory_controller should not go into FINALIZED state when fails to configure, remain in UNCONFIGURED


Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants