-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS2 Control Components - PositionJoint #140
Conversation
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
=======================================
Coverage 37.25% 37.25%
=======================================
Files 44 44
Lines 1863 1863
Branches 1136 1136
=======================================
Hits 694 694
Misses 130 130
Partials 1039 1039
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
So initial implementation is finished. Very simple and functional. |
@bmagyar something strange happened with the docker server. is it possible to restart the jobs manually? I am not able to do that... |
c190a0e
to
6b0aca3
Compare
This will be considered in #219 is abstraction of Joint is needed/wanted. Closing as discussed in the meeting on 21st of October 2020. |
…n interfaces (ros-controls#140) * Test position only version of JTC for KUKA RSI robots. * All changes in JTC added * Don't freak out when wait set can't be established * Test should expect that before a run, controller is unconfigured as well as after an unsuccessful configure call * joint_trajectory_controller should not go into FINALIZED state when fails to configure, remain in UNCONFIGURED Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
This PR creates
ros2_control_components
package and the implementation ofPositionJoint
component.It also influenced
hardware_interface
package by:component_lists_management.hpp
file is moved toinclude
folder to be accessible from other packagescomponent_lists_management.hpp
with limit handling functionsJoint
andSensor
classes virtual