Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on composite controllers? #12

Closed
jbohren opened this issue Jun 13, 2013 · 5 comments
Closed

Thoughts on composite controllers? #12

jbohren opened this issue Jun 13, 2013 · 5 comments

Comments

@jbohren
Copy link
Member

jbohren commented Jun 13, 2013

A while back I put some composite controllers together for adding the outputs of controllers together by just making a controller into a hierarchical structure. It works with un-modified ros_control.

https://github.com/jhu-lcsr/composite_controllers

Any feedback is welcome!

@davetcoleman
Copy link
Member

I'm going to assume you've given up on this feature? Should this issue be closed?

@jbohren
Copy link
Member Author

jbohren commented Sep 19, 2013

Yes, and yes.

@maxpolzin
Copy link

maxpolzin commented Jan 21, 2022

It is a pity you gave up on this. Now I have to create my own composite controller (effort+velocity), by implementing a new controller for ros_control.

@jbohren
Copy link
Member Author

jbohren commented Jan 22, 2022

👍 necromancer.

Shouldn't it be better effort_average, instead of effort_sum in your example of a composite controller?

The motivating use case here was combining an inverse dynamics controller with some other effort controller, hence the sum.

It is a pity you gave up on this. Now I have to create my own composite controller (effort+velocity), by implementing a new controller for ros_control.

It quickly became apparent that I needed something more sophisticated, so I ended up using Orocos RTT, and built up this framework:

https://github.com/jbohren/conman

@maxpolzin
Copy link

Thanks a lot for the explanation.
And thanks for pointing me to the other framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants