soundplay_node no longer works on Hydro (v0.2.5)

[piyushk]

I get the following error trying to run the code:

bwi@calculon:~$ rosrun sound_play soundplay_node.py 
Traceback (most recent call last):
  File "/opt/ros/hydro/lib/sound_play/soundplay_node.py", line 368, in <module>
    soundplay()
  File "/opt/ros/hydro/lib/sound_play/soundplay_node.py", line 304, in __init__
    rootdir = os.path.join(roslib.packages.get_pkg_dir('sound_play'),'sounds')
NameError: global name 'roslib' is not defined

I believe this change is responsible:
f5a1355#diff-c4ecd77ae058b18c549f3b287bd340b4R304

As far as I can tell, roslib is never imported, and that seems to be the only error. I'll submit a PR.

[jack-oquin]

I believe roslib is no longer recommended for resolving package paths.

The preferred approach is:

import rospkg
rp = rospkg.RosPack()
try:
    pkg_path = rp.get_path(package)
except rospkg.ResourceNotFound:
    rospy.logwarn("unknown package: " + package + " (ignored)")

That requires this in the package.xml:

<run_depend>python-rospkg</run_depend>

[ahendrix]

Tested and released in sound_play 0.2.6: ros/rosdistro#3292