Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do call "UrgNode::run()" in latest code on ros2-devel branch #66

Closed
n-hamaike-esol opened this issue May 11, 2020 · 3 comments
Closed
Labels

Comments

@n-hamaike-esol
Copy link

n-hamaike-esol commented May 11, 2020

I'm trying to test "LaserScan Visualization" following this link(https://index.ros.org/p/urg_node/#dashing), but it doesn't work. (use UTM-30LX-EW)
The result of debugging, "UrgNode::run()" is not called.(I set break point by GDB but not stopped, and not called from anywhere in source code)

With refering to commit log, I guess it seems disappeared when "urg_node" modified to component node.
(ad15f23)

I added "UrgNode::run()" caller, then it works.

In latest code on ros2-devel branch, How do call "UrgNode::run()"?
"UrgNode::run()" caller is not necessary?

I'd appreciate it if someone could answer my questions.

@mikeferguson
Copy link
Member

So, here's the hack I added, seems to work (not sure if it breaks other compositions though): https://github.com/mikeferguson/urg_node/commit/f308eee4f6a567a01077f205db9d130124f564e0

@n-hamaike-esol
Copy link
Author

@mikeferguson
thanks for your comments and fixes!

mikeferguson added a commit that referenced this issue Jun 10, 2020
@mikeferguson
Copy link
Member

Merged the proper fix - will do a release shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants