-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix deprecation warning #69
fix deprecation warning #69
Conversation
Tested on Foxy with a ust-20lx |
This won't work on Dashing, so we should probably merge #71 and do a new/final release to dashing before merging this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that deprecated API has been removed, releasing this patch into rolling
should fix http://build.ros2.org/view/Rbin_uF64/job/Rbin_uF64__urg_node__ubuntu_focal_amd64__binary/17/
src/urg_node.cpp
Outdated
@@ -116,7 +116,7 @@ void UrgNode::initSetup() | |||
|
|||
diagnostic_updater_.add("Hardware Status", this, &UrgNode::populateDiagnosticsStatus); | |||
|
|||
this->set_on_parameters_set_callback(std::bind(&UrgNode::param_change_callback, this, | |||
this->add_on_set_parameters_callback(std::bind(&UrgNode::param_change_callback, this, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to hold a reference to the returned shared pointer, otherwise the callback may be unregistered.
passes, has crustify issues on F/R - which I'll fix in separate PR |
same problem on ubuntu 18.04 dashing |
No description provided.